Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify warning about edge + ISR support #47452

Merged
merged 2 commits into from Mar 23, 2023
Merged

clarify warning about edge + ISR support #47452

merged 2 commits into from Mar 23, 2023

Conversation

EndangeredMassa
Copy link
Contributor

@EndangeredMassa EndangeredMassa commented Mar 23, 2023 •
edited

Made two tweaks:

  • renamed experimental-edge to edge: do we still need to reference experimental-edge?
  • added "you" for clarity of word flow

@EndangeredMassa EndangeredMassa marked this pull request as ready for review March 23, 2023 18:35
timneutkens
timneutkens requested changes Mar 23, 2023
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using rendering is currently experimental while api routes are stable with edge enabled, so in this case experimental-edge is correct.

@timneutkens
Copy link
Member

Good catch, thanks!

@ijjk ijjk merged commit 3d93960 into vercel:canary Mar 23, 2023
90 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens timneutkens approved these changes

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@ijjk ijjk ijjk approved these changes

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@jankaifer jankaifer Awaiting requested review from jankaifer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EndangeredMassa @timneutkens @styfle @balazsorban44 @ijjk