Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev ipc request on node v16 #47825

Merged
merged 1 commit into from Apr 2, 2023
Merged

Fix dev ipc request on node v16 #47825

merged 1 commit into from Apr 2, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 2, 2023

This ensures we filter conflicting headers from the initial request when passing it to a render worker since undici in Node.js v16 fails on these.

x-ref: https://github.com/vercel/next.js/actions/runs/4588955268/jobs/8105263272

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Apr 2, 2023
@ijjk ijjk merged commit 819453e into vercel:canary Apr 2, 2023
91 of 92 checks passed
@ijjk ijjk deleted the fix/fetch-node-16 branch April 2, 2023 18:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk