Revert "Vendor react@experimental under an experimentalReact flag"
#48038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
a team,
huozhi and
feedthejim
as code owners
ijjk
added
area: tests
created-by: Next.js team
huozhi
approved these changes
Apr 6, 2023
shuding
approved these changes
Apr 6, 2023
styfle
approved these changes
Apr 6, 2023
ijjk
deleted the
revert-47759-shuding/next-926-add-an-experimental-flag-to-switch-to
branch
shuding
added a commit
that referenced
this pull request
Apr 8, 2023
…g" (#48041) Reverts #48038 fix NEXT-926 --- The root cause was that when copying the package.json, I removed all fields except for a few (such as `exports`) but missed the `browser` field. That caused the client bundle to resolve to the Node.js version of React DOM, and then we had the `async_hooks` error. Added it back in 99c9b9e. I reproduced the error with next-site earlier and confirmed that this fix is good.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-ref: slack thread
Reverts #47759
fix NEXT-926