Lazy DevHtmlAsset chunk generation #48768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkirsz
requested review from
timneutkens,
ijjk,
shuding and
a team
as code owners
ijjk
added
Turbopack
alexkirsz
force-pushed
the
alexkirsz/web-944-perf-regression
branch
from
b068ce0
to
d00fa36
Compare
sokra
previously approved these changes
Apr 24, 2023
alexkirsz
force-pushed
the
alexkirsz/web-944-perf-regression
branch
2 times, most recently
from
e7e3901
to
20056bd
Compare
sokra
previously approved these changes
Apr 24, 2023
alexkirsz
force-pushed
the
alexkirsz/web-944-perf-regression
branch
from
20056bd
to
a5607a4
Compare
sokra
approved these changes
Apr 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a perf regression introduced in the chunking refactor, where we would be eagerly generating all assets from the web entry and fallback sources.
See vercel/turbo#4679
This also brings the following updates from vercel/turbo: