Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting runtime in layouts in type declarations #49117

Merged
merged 1 commit into from May 2, 2023
Merged

Allow setting runtime in layouts in type declarations #49117

merged 1 commit into from May 2, 2023

Conversation

shuding
Copy link
Member

@shuding shuding commented May 2, 2023

Since we're allowing setting runtime in layout files, this PR fixes the type guard plugin. Closes #49079.

@shuding shuding requested review from timneutkens, ijjk, a team and huozhi as code owners May 2, 2023 22:46
@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 2, 2023
@kodiakhq kodiakhq bot merged commit 2994668 into canary May 2, 2023
102 checks passed
@kodiakhq kodiakhq bot deleted the shu/b081 branch May 2, 2023 23:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime in layout gives type error
3 participants
@shuding @huozhi @ijjk