Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override icon rel #49194

Merged
merged 1 commit into from May 4, 2023
Merged

Allow override icon rel #49194

merged 1 commit into from May 4, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 4, 2023 •
edited

Fixes #48392

When passing down Array<IconDescriptor>, it should allow overriding rel prop of icon instead of always picking the default one
fix NEXT-1085

@huozhi huozhi marked this pull request as ready for review May 4, 2023 08:32
@kodiakhq kodiakhq bot merged commit bf09c65 into vercel:canary May 4, 2023
94 checks passed
@huozhi huozhi deleted the metadata/override-rel branch May 4, 2023 09:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feedthejim feedthejim feedthejim approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
area: tests created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NEXT-1085] Icon not appearing from metadata
3 participants
@huozhi @feedthejim @ijjk