Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect React env in particular case #49202

Merged
merged 2 commits into from May 4, 2023
Merged

Fix incorrect React env in particular case #49202

merged 2 commits into from May 4, 2023

Conversation

shuding
Copy link
Member

@shuding shuding commented May 4, 2023

The value of __NEXT_PRIVATE_PREBUNDLED_REACT has to be a correct React channel.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 4, 2023
@ijjk
Copy link
Member

ijjk commented May 4, 2023

Failing test suites

Commit: c3b12ac

pnpm testheadless test/e2e/middleware-fetches-with-body/index.test.ts

  • Middleware fetches with body > with custom bodyParser sizeLimit (5mb) > should return 413 for body equal to 10mb
Expand output

● Middleware fetches with body › with custom bodyParser sizeLimit (5mb) › should return 413 for body equal to 10mb

expect(received).toBe(expected) // Object.is equality

Expected: 413
Received: 500

  177 |       )
  178 |
> 179 |       expect(res.status).toBe(413)
      |                          ^
  180 |
  181 |       if (!(global as any).isNextDeploy) {
  182 |         expect(res.statusText).toBe('Body exceeded 5mb limit')

  at Object.<anonymous> (e2e/middleware-fetches-with-body/index.test.ts:179:26)

Read more about building and testing Next.js in contributing.md.

@feedthejim feedthejim merged commit 83e46fd into canary May 4, 2023
94 of 97 checks passed
@feedthejim feedthejim deleted the shu/237f branch May 4, 2023 12:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants