Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow overwriting the
global.crypto
property when polyfilling it.Why?
#48941 introduced
global.crypto
polyfill. The problem is that if some library (e.g. xksuid) tries to do the same thing, it breaks asglobal.crypto
is defined as non-writable1. Arguably libraries should check forglobal.crypto
presence before overwriting it BUT I think polyfill should match the actual implementation2.How?
Make
global.crypto
enumerable
andconfigurable
, as well as defineset
implementation3.Footnotes
↩
↩
↩