Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix flaky middleware matcher test #49555

Merged
merged 1 commit into from May 9, 2023
Merged

chore: fix flaky middleware matcher test #49555

merged 1 commit into from May 9, 2023

Conversation

styfle
Copy link
Member

@styfle styfle commented May 9, 2023 

    ✕ should match query path (2857 ms)

  ● Middleware custom matchers basePath › should match query path

    expect(received).toBe(expected) // Object.is equality

    Expected: "random"
    Received: ""

https://github.com/vercel/next.js/actions/runs/4929337370/jobs/8809028722?pr=49529#step:6:201

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels May 9, 2023
@kodiakhq kodiakhq bot merged commit 064e0c2 into canary May 9, 2023
101 checks passed
@kodiakhq kodiakhq bot deleted the fix-flaky-middleware-matcher-basepath-test branch May 9, 2023 22:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
area: tests created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@styfle @ijjk