New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Clarify that merely changing extension
does not load .md
f…
#49785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles as MDX I got bitten by this passage because it reads as if merely changing the `extension` setting will cause `.md` files to be loaded as MDX. See: mdx-js/mdx#2302
joostdecock
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
May 14, 2023 18:10
4 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joostdecock, I appreciate you updating the docs!
Some ideas on adding some additional clarity noted below.
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
timneutkens
previously approved these changes
May 15, 2023
Can you fix the linting? Then it can be landed 👍 |
ChristianMurphy
approved these changes
May 15, 2023
ijjk
approved these changes
Jun 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iles as MDX
I got bitten by this passage because it reads as if merely changing the
extension
setting will cause.md
files to be loaded as MDX.See: mdx-js/mdx#2302