Update fetch dynamic error handling #50822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
requested review from
timneutkens,
shuding,
huozhi and
feedthejim
as code owners
ijjk
added
area: tests
created-by: Next.js team
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
Updates to not throw the dynamic server error inside of the patched fetch as it's typical for fetch errors to be caught and handled and this error is not meant to be caught by users. This instead throws it during rendering so we can ensure we catch it instead of users. x-ref: https://github.com/vercel/next.js/actions/runs/5182384027/jobs/9339123096
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to not throw the dynamic server error inside of the patched fetch as it's typical for fetch errors to be caught and handled and this error is not meant to be caught by users. This instead throws it during rendering so we can ensure we catch it instead of users.
x-ref: https://github.com/vercel/next.js/actions/runs/5182384027/jobs/9339123096