Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Clarify a few things about the instrumentation.ts file #51034

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

delbaoliveira
Copy link
Contributor

There was some confusion about where to place it.

@renanbandeira
Copy link

Hi @delbaoliveira are you sure this is correct? I ran with this issue and when I read this (and actualy added some logs there), I realized that only src files are reaching this line

@feedthejim
Copy link
Contributor

@renanbandeira can you open a repro with the setup you're having? It sounds like a bug to me

@kodiakhq kodiakhq bot merged commit 9800eaf into canary Jun 9, 2023
@kodiakhq kodiakhq bot deleted the docs-nz8s branch June 9, 2023 13:40
@renanbandeira
Copy link

renanbandeira commented Jun 10, 2023

@renanbandeira can you open a repro with the setup you're having? It sounds like a bug to me

@feedthejim Sure! You can take a look at it here. Basically I took the api-routes example, added the instrumentation files and configuration from the with-opentelemetry example and added the files to the src folder

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants