Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXT-1282] Favicon metadata on windows href uses wrong slashes #51086

Closed
1 task done
partridge1307 opened this issue Jun 10, 2023 · 1 comment · Fixed by #51088
Closed
1 task done

[NEXT-1282] Favicon metadata on windows href uses wrong slashes #51086

partridge1307 opened this issue Jun 10, 2023 · 1 comment · Fixed by #51088
Assignees
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked Metadata Related to Next.js' Metadata API.

Comments

@partridge1307
Copy link

partridge1307 commented Jun 10, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: win32
      Arch: x64
      Version: Windows 10 Home Single Language
    Binaries:
      Node: 18.16.0
      npm: N/A
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.4.4
      eslint-config-next: 13.4.4
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.3

Which area(s) of Next.js are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue or a replay of the bug

https://github.com/partridge1307/favicon-error

To Reproduce

npm install

Describe the Bug

On window seem like favicon has error wrong display path image but on Linux it normal here is favicon dir
image

Expected Behavior

Show favicon

Which browser are you using? (if relevant)

Opera GX

How are you deploying your application? (if relevant)

No response

NEXT-1282

@partridge1307 partridge1307 added the bug Issue was opened via the bug report template. label Jun 10, 2023
@huozhi huozhi changed the title Favicon bug Favicon metadata on windows href uses wrong slashes Jun 10, 2023
@huozhi huozhi added the Metadata Related to Next.js' Metadata API. label Jun 10, 2023
@huozhi huozhi self-assigned this Jun 10, 2023
@huozhi huozhi added the linear: next Confirmed issue that is tracked by the Next.js team. label Jun 10, 2023
@huozhi huozhi changed the title Favicon metadata on windows href uses wrong slashes [NEXT-1282] Favicon metadata on windows href uses wrong slashes Jun 10, 2023
@kodiakhq kodiakhq bot closed this as completed in #51088 Jun 10, 2023
kodiakhq bot pushed a commit that referenced this issue Jun 10, 2023
Fixes #51086

The path is used as href, should be normalized as posix style
fix NEXT-1282
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked Metadata Related to Next.js' Metadata API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants