Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: improve with-supabase example #51442

Merged
merged 21 commits into from Jun 21, 2023

Conversation

dijonmusters
Copy link
Contributor

@dijonmusters dijonmusters commented Jun 17, 2023

What?

  1. Opt App Router examples out of routing:
  2. Follow Supabase directory convention for init and seed scripts

Why?

  1. Example routes are being rendered and fail if the user has not run the seed step of the README.md
  2. SQL statements are in README.md

How?

  1. Move all example routes under /app/_examples/
  2. Move structural SQL statements to /supabase/migrations/...init.sql and seed ones to /supabase/seed.sql

@ijjk ijjk added the examples Issue/PR related to examples label Jun 17, 2023
@vercel-spaces vercel-spaces bot requested a review from leerob June 17, 2023 11:09
@ijjk
Copy link
Member

ijjk commented Jun 17, 2023

Allow CI Workflow Run

  • approve CI run for commit: 4ca212d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@dijonmusters dijonmusters force-pushed the chore/opt-examples-out-of-routing branch from d682d4a to df1f8b3 Compare June 17, 2023 11:12
@dijonmusters dijonmusters changed the title examples: opt with-supabase examples out of routing examples: improve with-supabase example Jun 18, 2023
@dijonmusters dijonmusters force-pushed the chore/opt-examples-out-of-routing branch from 07dae64 to c580bf4 Compare June 18, 2023 10:58
@dijonmusters dijonmusters force-pushed the chore/opt-examples-out-of-routing branch from 978c4de to b4e47d3 Compare June 20, 2023 04:47
examples/with-supabase/app/page.tsx Outdated Show resolved Hide resolved
examples/with-supabase/app/page.tsx Outdated Show resolved Hide resolved
dijonmusters and others added 4 commits June 20, 2023 22:15
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
@vercel-spaces
Copy link

vercel-spaces bot commented Jun 20, 2023

Notifying the following users due to files changed in this PR:

@timneutkens, @ijjk, @shuding, @huozhi, @feedthejim:

examples/with-supabase/README.md
examples/with-supabase/app/_examples/client-component/page.tsx
examples/with-supabase/app/_examples/protected-route/page.tsx
examples/with-supabase/app/_examples/route-handler/route.ts
examples/with-supabase/app/_examples/server-action/page.tsx
examples/with-supabase/app/_examples/server-component/page.tsx
examples/with-supabase/app/layout.tsx
examples/with-supabase/app/login/page.tsx
examples/with-supabase/app/logout-button.tsx
examples/with-supabase/app/page.tsx
examples/with-supabase/public/book.svg
examples/with-supabase/public/code.svg
+5 more

This comment was posted based on the notify modifier.

@leerob leerob merged commit 0674d95 into vercel:canary Jun 21, 2023
18 of 22 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants