Update 01-images.mdx #51532
Merged
Update 01-images.mdx #51532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the size of grid tracks specified in the CSS I added complimentary usage of sizes attribute. You can ascertain the media based on the `gridTemplateColumns` and `gridGap` values.
morganfeeney
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi and
a team
as code owners
ijjk
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the size of grid tracks specified in the CSS I amended the usage of the HTML
sizesattribute.The media can be ascertained from
gridTemplateColumnsandgridGapvalues, this change results in smaller images also being available in the srcset for use with sizes, which should be more performant.