refactor(tests): make chain more "correct"

[ForsakenHarmony]

Why?

I really dislike the way .chain works right now, it shouldn't mutate the BrowserInterface, this PR changes it so it's just a pure chain without weird side effects.

One example with the current version (before this PR):

const el = browser.elementByCss('#version-2')
await el.text()
// throws
await el.text()

Additional Changes

• removes selenium (which is completely unused)
• updates playwright
• makes the playwright tracing not error all the time

[ijjk]

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
buildDuration	13.4s	13.3s	N/A
buildDurationCached	7.2s	6.3s	N/A
nodeModulesSize	196 MB	196 MB	N/A
nextStartRea..uration (ms)	459ms	459ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
3f784ff6-HASH.js gzip	53.5 kB	53.5 kB	N/A
423.HASH.js gzip	185 B	181 B	N/A
68-HASH.js gzip	29.6 kB	29.6 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	238 B	239 B	N/A
main-HASH.js gzip	31.9 kB	31.9 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	46.9 kB	46.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	182 B	181 B	N/A
amp-HASH.js gzip	502 B	501 B	N/A
css-HASH.js gzip	320 B	322 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	255 B	256 B	N/A
head-HASH.js gzip	350 B	349 B	N/A
hooks-HASH.js gzip	368 B	369 B	N/A
image-HASH.js gzip	4.2 kB	4.2 kB	N/A
index-HASH.js gzip	257 B	256 B	N/A
link-HASH.js gzip	2.67 kB	2.67 kB	N/A
routerDirect..HASH.js gzip	310 B	311 B	N/A
script-HASH.js gzip	384 B	383 B	N/A
withRouter-HASH.js gzip	306 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	106 B	106 B	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
_buildManifest.js gzip	483 B	484 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
index.html gzip	528 B	527 B	N/A
link.html gzip	543 B	540 B	N/A
withRouter.html gzip	524 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
edge-ssr.js gzip	94.4 kB	94.4 kB	N/A
page.js gzip	150 kB	150 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
middleware-b..fest.js gzip	620 B	625 B	N/A
middleware-r..fest.js gzip	151 B	149 B	N/A
middleware.js gzip	47.4 kB	47.4 kB	N/A
edge-runtime..pack.js gzip	1.94 kB	1.94 kB	✓
Overall change	1.94 kB	1.94 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js hrmny/chain-correctness	Change
app-page-exp...dev.js gzip	166 kB	166 kB	✓
app-page-exp..prod.js gzip	95.4 kB	95.4 kB	✓
app-page-tur..prod.js gzip	97.2 kB	97.2 kB	✓
app-page-tur..prod.js gzip	91.6 kB	91.6 kB	✓
app-page.run...dev.js gzip	136 kB	136 kB	✓
app-page.run..prod.js gzip	90.2 kB	90.2 kB	✓
app-route-ex...dev.js gzip	22 kB	22 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.7 kB	14.7 kB	✓
app-route.ru...dev.js gzip	21.7 kB	21.7 kB	✓
app-route.ru..prod.js gzip	14.7 kB	14.7 kB	✓
pages-api-tu..prod.js gzip	9.43 kB	9.43 kB	✓
pages-api.ru...dev.js gzip	9.7 kB	9.7 kB	✓
pages-api.ru..prod.js gzip	9.43 kB	9.43 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	22.7 kB	22.7 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	49.9 kB	49.9 kB	✓
Overall change	924 kB	924 kB	✓

Commit: 269c86d

[ijjk]

Tests Passed

[ForsakenHarmony]

• canary
  • refactor(tests): make chain more "correct" #51728 👈

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ForsakenHarmony and the rest of your teammates on Graphite

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@playwright/test@1.41.2	Transitive: environment, eval, filesystem, network, shell, unsafe	+2	10.1 MB	yurys
npm/playwright-chromium@1.41.2	Transitive: environment, eval, filesystem, network, shell, unsafe	+1	7.2 MB	dgozman-ms, pavelfeldman, yurys
npm/playwright@1.41.2	Transitive: environment, eval, filesystem, network, shell, unsafe	+1	10.1 MB	yurys

🚮 Removed packages: npm/@playwright/test@1.35.1, npm/playwright-chromium@1.35.1, npm/playwright-core@1.35.1

View full report↗︎

[ForsakenHarmony]

This unfortunately does not work as you have to stop tracing before the page gets closed