Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Typesafe metadata object #52252

Merged
merged 14 commits into from Jul 10, 2023
Merged

chore(docs): Typesafe metadata object #52252

merged 14 commits into from Jul 10, 2023

Conversation

carlos-menezes
Copy link
Contributor

Adds missing Metadata type to a few declarations.

@carlos-menezes carlos-menezes requested review from a team as code owners July 5, 2023 13:15
timneutkens
timneutkens previously requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these are .js files 🤔

delbaoliveira
delbaoliveira previously approved these changes Jul 6, 2023
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Jul 6, 2023 •
edited by styfle

Allow CI Workflow Run

  • approve CI run for commit: 508d5a4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

styfle
styfle previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle styfle dismissed timneutkens’s stale review July 6, 2023 14:46

changes were addressed

@styfle styfle changed the title Typesafe metadata object chore(docs): Typesafe metadata object Jul 6, 2023
@styfle styfle dismissed stale reviews from delbaoliveira and themself via 476f2dc July 6, 2023 20:54
styfle
styfle previously approved these changes Jul 6, 2023
View reviewed changes
@delbaoliveira delbaoliveira self-requested a review July 7, 2023 07:09
@styfle @delbaoliveira
Apply suggestions from code review
fcd3d37 
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
styfle
styfle previously approved these changes Jul 7, 2023
View reviewed changes
leerob
leerob previously approved these changes Jul 9, 2023
View reviewed changes
@timneutkens timneutkens dismissed stale reviews from leerob and styfle via 5b72e61 July 10, 2023 09:19
@timneutkens timneutkens merged commit 9ea188a into vercel:canary Jul 10, 2023
8 checks passed
@github-actions github-actions bot added the locked label Aug 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delbaoliveira delbaoliveira delbaoliveira left review comments

@styfle styfle styfle left review comments

@leerob leerob leerob left review comments

@S3Prototype S3Prototype Awaiting requested review from S3Prototype S3Prototype is a code owner automatically assigned from vercel/devex

@lydiahallie lydiahallie Awaiting requested review from lydiahallie lydiahallie is a code owner automatically assigned from vercel/devex

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@carlos-menezes @ijjk @styfle @timneutkens @leerob @delbaoliveira