Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct TypeScript spelling on the home page #52500

Merged
merged 5 commits into from Jul 10, 2023
Merged

docs: correct TypeScript spelling on the home page #52500

merged 5 commits into from Jul 10, 2023

Conversation

matepapp
Copy link
Contributor

What?

Changing the word TypeScript with an uppercase S.

Why?

  • Because that's the official recommendation from TypeScript. (Reference: typescriptlang.org)
  • The docs already uses this format (e.g. TypeScript page) so it's just a matter of consistency.

@matepapp matepapp requested review from a team as code owners July 10, 2023 12:17
@manovotny
Copy link
Contributor

Thanks @matepapp! 🙏

@ijjk
Copy link
Member

ijjk commented Jul 10, 2023 •
edited by manovotny

Allow CI Workflow Run

  • approve CI run for commit: 9981db6

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@matepapp
Copy link
Contributor Author

sorry @ijjk, I wasn't aware of this requirement

@manovotny
Copy link
Contributor

@matepapp nothing to apologize about here. It's an automated message for me as a maintainer. You've done your part. 😊

@kodiakhq kodiakhq bot merged commit b450895 into vercel:canary Jul 10, 2023
39 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manovotny manovotny manovotny approved these changes

@StephDietz StephDietz Awaiting requested review from StephDietz StephDietz is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matepapp @manovotny @ijjk