Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 02-edge-and-nodejs-runtimes.mdx #52888

Merged
merged 3 commits into from Jul 19, 2023
Merged

Update 02-edge-and-nodejs-runtimes.mdx #52888

merged 3 commits into from Jul 19, 2023

Conversation

steven-tey
Copy link
Contributor

@steven-tey steven-tey commented Jul 19, 2023 •
edited

Added clarification that runtime edge can be defined on Layout level too.

@steven-tey steven-tey requested review from a team as code owners July 19, 2023 14:06
styfle
styfle previously approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@styfle @timneutkens
Apply suggestion for "routes"
5c7ef09 
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
styfle
styfle previously approved these changes Jul 19, 2023
View reviewed changes
@kodiakhq kodiakhq bot merged commit 55fdfe4 into canary Jul 19, 2023
47 checks passed
@kodiakhq kodiakhq bot deleted the layout-edge-runtime branch July 19, 2023 14:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@styfle styfle styfle left review comments

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@delbaoliveira delbaoliveira Awaiting requested review from delbaoliveira delbaoliveira is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
created-by: Next.js DevEx team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@steven-tey @styfle @timneutkens @balazsorban44 @ijjk