Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make next as dependency of @next/third-parties package #53996

Merged
merged 9 commits into from Aug 14, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Aug 14, 2023

ensure next is the dependency of third-parties package so turbo will build next first then @next/third-parties to avoid type failing

@huozhi huozhi changed the title Fix build pipeline for third party package Fix build pipeline for third parties package Aug 14, 2023
@ijjk
Copy link
Member

ijjk commented Aug 14, 2023

Failing test suites

Commit: 8df4adb

pnpm testheadless test/e2e/app-dir/third-parties/basic.test.ts

  • @next/third-parties basic usage > renders YoutubeEmbed
  • @next/third-parties basic usage > renders GoogleMapsEmbed
Expand output

● @next/third-parties basic usage › renders YoutubeEmbed

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  15 |       const baseContainer = $('[data-ntpc="YoutubeEmbed"]')
  16 |       const youtubeContainer = $('lite-youtube')
> 17 |       expect(baseContainer.length).toBe(1)
     |                                    ^
  18 |       expect(youtubeContainer.length).toBe(1)
  19 |     })
  20 |

  at Object.<anonymous> (e2e/app-dir/third-parties/basic.test.ts:17:36)

● @next/third-parties basic usage › renders GoogleMapsEmbed

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 0

  26 |         '[src="https://www.google.com/maps/embed/v1/place?key=XYZ&q=Brooklyn+Bridge,New+York,NY"]'
  27 |       )
> 28 |       expect(baseContainer.length).toBe(1)
     |                                    ^
  29 |       expect(mapContainer.length).toBe(1)
  30 |     })
  31 |   }

  at Object.<anonymous> (e2e/app-dir/third-parties/basic.test.ts:28:36)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi changed the title Fix build pipeline for third parties package Make next as dependency of @next/third-parties package Aug 14, 2023
@huozhi huozhi requested a review from styfle August 14, 2023 14:23
styfle
styfle previously approved these changes Aug 14, 2023
shuding
shuding previously approved these changes Aug 14, 2023
@huozhi huozhi dismissed stale reviews from shuding and styfle via b8edb3d August 14, 2023 15:34
@huozhi huozhi requested review from a team as code owners August 14, 2023 15:34
styfle
styfle previously approved these changes Aug 14, 2023
@ijjk ijjk requested a review from a team as a code owner August 14, 2023 15:39
@ijjk ijjk requested review from leerob and Nutlope August 14, 2023 15:39
@huozhi huozhi requested review from ijjk and styfle August 14, 2023 15:51
@ijjk ijjk merged commit 3f83743 into canary Aug 14, 2023
48 of 53 checks passed
@ijjk ijjk deleted the fix-third-party/build branch August 14, 2023 15:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants