Revert "fix(47299): allow testing pages with metadata in jsdom test environment" #54160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huozhi
requested review from
timneutkens,
ijjk,
shuding,
a team,
feedthejim and
ztanner
as code owners
ijjk
added
area: tests
created-by: Next.js team
timneutkens
approved these changes
Aug 17, 2023
kodiakhq
bot
deleted the
revert-53578-fix/47299-test-page-with-metadata
branch
X-oss-byte
pushed a commit
to X-oss-byte/next.js
that referenced
this pull request
Aug 17, 2023
…nvironment" (vercel#54160) Reverts vercel#53578 This PR (vercel#53578) will break client components test, revert it for now. Can repro by adding `"use client"` to `app/page.tsx` in `test/production/jest/server-only.test.ts` ``` FAIL app/page.test.jsx ● Test suite failed to run· Cannot find module 'private-next-rsc-mod-ref-proxy' from 'app/page.jsx'· Require stack: ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #53578
This PR (#53578) will break client components test, revert it for now.
Can repro by adding
"use client"toapp/page.tsxintest/production/jest/server-only.test.ts