Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typedRoutes does not work while running on the dev server #54168

Closed
1 task done
Karibash opened this issue Aug 17, 2023 · 1 comment · Fixed by #54224
Closed
1 task done

typedRoutes does not work while running on the dev server #54168

Karibash opened this issue Aug 17, 2023 · 1 comment · Fixed by #54224
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked Navigation Related to Next.js linking (e.g., <Link>) and navigation. TypeScript Related to types with Next.js.

Comments

@Karibash
Copy link

Karibash commented Aug 17, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:22 PDT 2023; root:xnu-8796.121.3~7/RELEASE_X86_64
    Binaries:
      Node: 18.17.1
      npm: 9.6.7
      Yarn: N/A
      pnpm: 8.6.12
    Relevant Packages:
      next: 13.4.16
      eslint-config-next: 13.4.16
      react: 18.2.0
      react-dom: 18.2.0
      typescript: 5.1.6
    Next.js Config:
      output: N/A

Which area(s) of Next.js are affected? (leave empty if unsure)

Routing (next/router, next/navigation, next/link)

Link to the code that reproduces this issue or a replay of the bug

I will prepare it later.

To Reproduce

Start the development server with typedRoutes enabled.

Describe the Bug

Due to the following PR, devPageFiles are no longer being updated, so link type definition files are not being generated properly while running the development server.
https://github.com/vercel/next.js/pull/52492/files#diff-2f6fd5a9538abfaf3d5b76a82a8d1ffa029f84a36f0cdae5460520c5cfc2db6bL84

Currently devPageFiles is not updated from anywhere.
https://github.com/search?q=repo%3Avercel%2Fnext.js%20devPageFiles&type=code

Expected Behavior

A link type definition file is generated while the development server is running.

Which browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

NEXT-1531

@Karibash Karibash added the bug Issue was opened via the bug report template. label Aug 17, 2023
@github-actions github-actions bot added the Navigation Related to Next.js linking (e.g., <Link>) and navigation. label Aug 17, 2023
@balazsorban44 balazsorban44 added area: experimental TypeScript Related to types with Next.js. labels Aug 17, 2023
@shuding shuding added the linear: next Confirmed issue that is tracked by the Next.js team. label Aug 18, 2023
@kodiakhq kodiakhq bot closed this as completed in #54224 Aug 18, 2023
kodiakhq bot pushed a commit that referenced this issue Aug 18, 2023
Closes #54168. This was accidentally removed from a code refactoring.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot added the locked label Sep 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team. locked Navigation Related to Next.js linking (e.g., <Link>) and navigation. TypeScript Related to types with Next.js.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants