Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows next-swc builds #54353

Merged
merged 1 commit into from Aug 21, 2023
Merged

Fix windows next-swc builds #54353

merged 1 commit into from Aug 21, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 21, 2023

Fixes this build error on windows due to invalid path:

 Error: error: invalid path 'test/e2e/app-dir/app/app/bootstrap/[[...*]]/ClientComponent.js'
 Error: The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

x-ref: https://github.com/vercel/next.js/actions/runs/5930602201/job/16080672888#step:7:62

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels Aug 21, 2023
orca-security-us[bot]
orca-security-us bot reviewed Aug 21, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
passed Passed Secrets high 0  medium 0  low 0  info 0

@ijjk ijjk merged commit 0e91c79 into vercel:canary Aug 21, 2023
49 of 52 checks passed
@ijjk ijjk deleted the ci/fix-windows-builds branch August 21, 2023 20:35
@github-actions github-actions bot added the locked label Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

Assignees
No one assigned
Labels
area: tests created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk