Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update Edge runtime and data revalidation information #54499

Merged
merged 6 commits into from Aug 27, 2023
Merged

Conversation

delbaoliveira
Copy link
Contributor

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

leerob
leerob previously approved these changes Aug 24, 2023
@@ -27,7 +27,9 @@ There are many considerations to make when choosing a runtime. This table shows
| Security | Normal | High | High |
| Latency | Normal | Low | Lowest |
| npm Packages | All | All | A smaller subset |
| Revalidation | Yes | Yes | No |
| [Static Rendering](/docs/app/building-your-application/rendering/static-and-dynamic#static-rendering-default) | Yes | Yes | No |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Edge "No" for static rendering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| Revalidation | Yes | Yes | No |
| [Static Rendering](/docs/app/building-your-application/rendering/static-and-dynamic#static-rendering-default) | Yes | Yes | No |
| [Dynamic Rendering](/docs/app/building-your-application/rendering/static-and-dynamic#dynamic-rendering) | Yes | Yes | Yes |
| [Data Revalidation w/ `fetch`](/docs/app/building-your-application/data-fetching/fetching-caching-and-revalidating#revalidating-data) | Yes | Yes | Yes |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this PR was supposed to say Edge "No" for revalidation but I see "Yes" here :thonking2:

ijjk
ijjk previously approved these changes Aug 27, 2023
# Conflicts:
#	docs/02-app/01-building-your-application/02-data-fetching/01-fetching-caching-and-revalidating.mdx
@ijjk ijjk dismissed stale reviews from leerob and themself via a9e5ef2 August 27, 2023 01:24
ijjk
ijjk previously approved these changes Aug 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2023

All broken links are now fixed, thank you!

@ijjk ijjk merged commit 05dbd9a into canary Aug 27, 2023
51 checks passed
@ijjk ijjk deleted the docs-3rgs branch August 27, 2023 01:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants