docs: fix source files hash calculation #54509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
ijjk
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Hi, this should be correct as is per the pattern matching documentation https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
balazsorban44
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
JJ, it looks to be the recommendation for hashFiles here: https://docs.github.com/en/actions/learn-github-actions/expressions#example-with-multiple-patterns
So the PR looks good to me. Thanks!
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
styfle
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I recently tried to cache the
.next/cachedirectory in a GitHub action following what was said in the documentation and realized that hashing the source files didn't work properly.This problem also occured in next-cache and was fixed by this PR.
This PR simply changes the example from the documentation to apply the same fix (stop using brackets in the patterns passed to
hashFiles).Hope it helps!
Improving Documentation
pnpm prettier-fixto fix formatting issues before opening the PR.