Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next-eslint): .eslintrc.json not being created by next lint on App Router #55104

Merged
merged 6 commits into from
Feb 5, 2024
Merged

fix(next-eslint): .eslintrc.json not being created by next lint on App Router #55104

merged 6 commits into from
Feb 5, 2024

Conversation

devjiwonchoi
Copy link
Contributor

@devjiwonchoi devjiwonchoi commented Sep 7, 2023

This PR fixes .eslintrc.json not being created after the user runs next lint and selects an option of Strict or Base.
The reason is that the lint check was looking for pages and src/pages only. Added app and src/app to be checked also.

Fixes: #55094
Fixes: #55102

@ijjk ijjk added the type: next label Sep 7, 2023
@ijjk
Copy link
Member

ijjk commented Sep 7, 2023

Allow CI Workflow Run

  • approve CI run for commit: 8cfedc2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Sep 7, 2023

Allow CI Workflow Run

  • approve CI run for commit: 8cfedc2

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Sep 7, 2023

Allow CI Workflow Run

  • approve CI run for commit: 46799c9

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 1   low 0   info 0 View in Orca

@devjiwonchoi devjiwonchoi changed the title fix: add app dir to create eslint if not exists fix: .eslintrc.json not being created by next lint Sep 7, 2023
@devjiwonchoi devjiwonchoi changed the title fix: .eslintrc.json not being created by next lint fix(next-eslint): .eslintrc.json not being created by next lint Sep 7, 2023
@devjiwonchoi devjiwonchoi marked this pull request as ready for review September 7, 2023 11:59
@devjiwonchoi devjiwonchoi changed the title fix(next-eslint): .eslintrc.json not being created by next lint fix(next-eslint): .eslintrc.json not being created by next lint on App Router Sep 7, 2023
@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
buildDuration 11.7s 11.6s N/A
buildDurationCached 6.2s 4.9s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +528 B
nextStartRea..uration (ms) 426ms 428ms N/A
Client Bundles (main, webpack)
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 501 B N/A
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.19 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 106 B 106 B
Client Build Manifests
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 538 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
edge-ssr.js gzip 94 kB 94.1 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.7 kB 37.7 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary devjiwonchoi/next.js fix/next-lint-not-creating-eslintrc-json Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: 9867e01

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ijjk ijjk merged commit 4c53843 into vercel:canary Feb 5, 2024
62 of 67 checks passed
@devjiwonchoi devjiwonchoi deleted the fix/next-lint-not-creating-eslintrc-json branch February 7, 2024 05:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command next lint does not generate .eslintrc.json on App Router "lint": "next lint" never start
3 participants