Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Error on Event Type payment_intent webhook #55493

Merged
merged 3 commits into from Sep 18, 2023
Merged

Type Error on Event Type payment_intent webhook #55493

merged 3 commits into from Sep 18, 2023

Conversation

roigecode
Copy link
Contributor

changedfailedfor payment_failed on line 45

What?

Error in line 45 on type of payment_intent

Why?

Example provided does not work

How?

Added 'payment_'

@roigecode
Type Error on Event Type payment_intent webhook
b4e931f 
changed failed for payment_failed on line 45
@roigecode roigecode requested review from a team as code owners September 17, 2023 11:23
@ijjk ijjk added the examples Issue/PR related to examples label Sep 17, 2023
orca-security-us[bot]
orca-security-us bot reviewed Sep 17, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@styfle styfle added the CI approved Approve running CI for fork label Sep 18, 2023
styfle
styfle approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This should probably be updated to avoid typos like this using the following pattern:

https://twitter.com/styfle/status/1208787362613989381

@kodiakhq kodiakhq bot merged commit 4c6d4b3 into vercel:canary Sep 18, 2023
49 checks passed
@github-actions github-actions bot added the locked label Oct 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us left review comments

@styfle styfle styfle approved these changes

@ismaelrumzan ismaelrumzan Awaiting requested review from ismaelrumzan ismaelrumzan is a code owner automatically assigned from vercel/devex

@molebox molebox Awaiting requested review from molebox molebox is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
CI approved Approve running CI for fork examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roigecode @styfle @ijjk