Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): internationalization middleware example #55645

Merged
merged 3 commits into from Sep 20, 2023

Conversation

GabenGar
Copy link
Contributor

  • remove the slash before pathname (already included in the value).
  • add search and hash values in redirected url:
    • retains these values on redirect
    • they already have ? and # respectively

- remove the slash before `pathname` (already included in the value).
- add `search` and `hash` values in redirected url:
   - retains these values on redirect
   - they already have `?` and `#` respectively
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added some suggestions, which make it unnecessary to remember passing the search params and the hash altogether.

@kodiakhq kodiakhq bot merged commit fcca4ce into vercel:canary Sep 20, 2023
53 checks passed
@GabenGar GabenGar deleted the fix-internationalization-middleware branch September 20, 2023 14:28
@github-actions github-actions bot added the locked label Oct 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants