Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css not load from node_module when run with mode: next dev --turbo #55785

Closed
1 task done
duypham90 opened this issue Sep 22, 2023 · 1 comment · Fixed by #56679
Closed
1 task done

Css not load from node_module when run with mode: next dev --turbo #55785

duypham90 opened this issue Sep 22, 2023 · 1 comment · Fixed by #56679
Labels
bug Issue was opened via the bug report template. locked Turbopack Related to Turbopack with Next.js.

Comments

@duypham90
Copy link

duypham90 commented Sep 22, 2023

Link to the code that reproduces this issue

https://codesandbox.io/p/sandbox/nice-star-fcnhf5

To Reproduce

  1. Visit codesanbox above
  2. npm run dev
  3. Do not show error but css seem not loading and effect to layout

The result as below:

Screenshot 2023-09-22 at 11 04 13 Screenshot 2023-09-22 at 11 05 50

Current vs. Expected behavior

The result work correct as expected if we follow the step as below:

  1. Visit codesanbox above
  2. Edit package.json and remove option --turbo
  3. npm run dev
  4. The result work as expected

Or use
next build

The result:

Screenshot 2023-09-22 at 11 08 14

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP PREEMPT_DYNAMIC Sun Aug  6 20:05:33 UTC 2023
Binaries:
  Node: 20.5.1
  npm: 9.8.0
  Yarn: 1.22.19
  pnpm: N/A
Relevant Packages:
  next: 13.5.3-canary.1
  eslint-config-next: 13.5.1
  react: 18.2.0
  react-dom: 18.2.0
  typescript: 5.2.2
Next.js Config:
  output: N/A

Which area(s) are affected? (Select all that apply)

Turbopack (--turbo)

Additional context

No response

@duypham90 duypham90 added the bug Issue was opened via the bug report template. label Sep 22, 2023
@github-actions github-actions bot added the Turbopack Related to Turbopack with Next.js. label Sep 22, 2023
@kodiakhq kodiakhq bot closed this as completed in #56679 Oct 10, 2023
kodiakhq bot pushed a commit that referenced this issue Oct 10, 2023
### What?

- closes #55785

Similar to #56539, next.config's sass applies webpack loaders to node_modules implicitly and this PR mimics those for the turbopack.


Closes WEB-1753
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for 2 weeks. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. locked Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant