Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Renamed function that is used by other name #56170

Merged
merged 2 commits into from Sep 28, 2023
Merged

docs: Renamed function that is used by other name #56170

merged 2 commits into from Sep 28, 2023

Conversation

bzhn
Copy link
Contributor

@bzhn bzhn commented Sep 28, 2023

In "app/actions.ts" the function is named like create(), but in "app/add-form.tsx" file "createTodo" function is imported and used. This is related to TypeScript examples, .js files are ok.

What?

Renamed a function.

Why?

There are two example files in docs (Error Handling section) and the app/add-form.tsx is importing function create from app/actions.ts by another name (createTodo).

How?

Fixed by renaming function to createTodo, to match .js file with the same example.

In "app/actions.ts" the function is named like create(), but in "app/add-form.tsx" file "createTodo" function is imported and used.
This is related to TypeScript examples, .js files are ok.
@bzhn bzhn requested review from a team as code owners September 28, 2023 14:58
@bzhn bzhn requested review from timeyoutakeit and Nutlope and removed request for a team September 28, 2023 14:58
@styfle styfle added the CI approved Approve running CI for fork label Sep 28, 2023
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kodiakhq kodiakhq bot merged commit 9cd46e3 into vercel:canary Sep 28, 2023
50 checks passed
@bzhn bzhn deleted the patch-2 branch October 2, 2023 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants