Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Prefer module over main on main fields for app router server compiler" #56766

Merged
merged 1 commit into from Oct 12, 2023
Merged

Revert "Prefer module over main on main fields for app router server compiler" #56766

merged 1 commit into from Oct 12, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Oct 12, 2023 •
edited

This was causing some issues with our deployments.

slack x-ref

@ztanner ztanner changed the title Revert #56532 Revert "Prefer module over main on main fields for app router server compiler" Oct 12, 2023
@ijjk
Copy link
Member

ijjk commented Oct 12, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js revert/56532 Change
buildDuration 10.6s 10.5s N/A
buildDurationCached 6.2s 6.4s ⚠️ +158ms
nodeModulesSize 172 MB 172 MB N/A
nextStartRea..uration (ms) 894ms 895ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js revert/56532 Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 50.9 kB 50.9 kB ✓
99.HASH.js gzip 182 B 182 B ✓
framework-HASH.js gzip 45.3 kB 45.3 kB ✓
main-app-HASH.js gzip 252 B 249 B N/A
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 96.4 kB 96.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js revert/56532 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js revert/56532 Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 1.08 kB 1.08 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js revert/56532 Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js revert/56532 Change
index.html gzip 528 B 530 B N/A
link.html gzip 540 B 543 B N/A
withRouter.html gzip 524 B 526 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js revert/56532 Change
edge-ssr.js gzip 93.8 kB 93.8 kB ✓
page.js gzip 152 kB 152 kB N/A
Overall change 93.8 kB 93.8 kB ✓
Middleware size
vercel/next.js canary vercel/next.js revert/56532 Change
middleware-b..fest.js gzip 625 B 622 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 1.92 kB 1.92 kB ✓
Commit: 0289643

@ztanner ztanner marked this pull request as ready for review October 12, 2023 21:36
@kodiakhq kodiakhq bot merged commit 476af24 into canary Oct 12, 2023
61 checks passed
@kodiakhq kodiakhq bot deleted the revert/56532 branch October 12, 2023 21:38
huozhi added a commit that referenced this pull request Oct 14, 2023
@huozhi
Revert "Revert "Prefer module over main on main fields for app router…
8108de4 
… server compiler" (#56766)"

This reverts commit 476af24.
huozhi added a commit that referenced this pull request Oct 16, 2023
@huozhi
Revert "Revert "Prefer module over main on main fields for app router…
c795d3e 
… server compiler" (#56766)"

This reverts commit 476af24.
huozhi added a commit that referenced this pull request Oct 17, 2023
@huozhi
Revert "Revert "Prefer module over main on main fields for app router…
36a223d 
… server compiler" (#56766)"

This reverts commit 476af24.
@huozhi huozhi mentioned this pull request Oct 17, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Oct 19, 2023
@huozhi
Prefer module over main on main fields for app router server compiler (…
a6d4c77 
…#56960)

Reverts #56766
Reland #56532 

x-ref: https://vercel.slack.com/archives/C04DUD7EB1B/p1697576563771229?thread_ts=1697146531.305779&cid=C04DUD7EB1B

This change was breaking package which was actually a dual package but marked as esm module, and when the package is ESM but import a CJS dependency without fully spepcified file path it will fail to resolve. The way is to either remove the esmodule type in package.json or change the import to full path import with extension for the package
@github-actions github-actions bot added the locked label Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ztanner @ijjk @styfle