Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http2 example issue #56768

Merged
merged 4 commits into from Oct 13, 2023
Merged

fix: http2 example issue #56768

merged 4 commits into from Oct 13, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Oct 12, 2023 •
edited by balazsorban44

What?

If the custom server uses app.render(xxx) will render the normal js files as server components in dev mode and cause 404 error when loading every non-HTML file.

How?

Fixes nodejs/help#4253, fixes #50270

@himself65 himself65 requested review from a team as code owners October 12, 2023 23:23
@himself65 himself65 requested review from timeyoutakeit and molebox and removed request for a team October 12, 2023 23:23
@ijjk ijjk added the examples Issue/PR related to examples label Oct 12, 2023
@ijjk
Copy link
Member

ijjk commented Oct 12, 2023 •
edited by balazsorban44

Allow CI Workflow Run

  • approve CI run for commit: 39c0c7c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Oct 12, 2023 •
edited by balazsorban44

Allow CI Workflow Run

  • approve CI run for commit: fa96d8b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@himself65 himself65 mentioned this pull request Oct 12, 2023
Closed
@styfle styfle added the CI approved Approve running CI for fork label Oct 13, 2023
styfle
styfle approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit ac8a603 into vercel:canary Oct 13, 2023
53 checks passed
@himself65 himself65 deleted the himself65/fix-url branch October 13, 2023 18:16
@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit is a code owner automatically assigned from vercel/devex

@molebox molebox Awaiting requested review from molebox molebox is a code owner automatically assigned from vercel/devex

Assignees
No one assigned
Labels
CI approved Approve running CI for fork examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
4 participants
@himself65 @ijjk @styfle @balazsorban44