Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix several typos #56788

Merged
merged 8 commits into from Oct 13, 2023
Merged

docs: fix several typos #56788

merged 8 commits into from Oct 13, 2023
+6 −6

Conversation

suravshrestha
Copy link
Contributor

Enviroment -> Environment

@suravshrestha suravshrestha requested review from a team as code owners October 13, 2023 11:50
@suravshrestha suravshrestha requested review from timeyoutakeit and molebox and removed request for a team October 13, 2023 11:50
@ijjk ijjk added the examples Issue/PR related to examples label Oct 13, 2023
@timneutkens
Copy link
Member

timneutkens commented Oct 13, 2023 •
edited by balazsorban44

@suravshrestha can you just put these in a single PR?

#56787
#56786
#56785
#56784
#56783

@suravshrestha
Copy link
Contributor Author

suravshrestha commented Oct 13, 2023 •
edited

@suravshrestha can you just put these in a single PR?

Please merge the PRs this time. In the future, I will combine commits of this type into a single PR. Thank you!

A follow up question, how should i group these types of files/commit? Can I group the PRs by parent directory?

This was referenced Oct 13, 2023
Closed
Closed
Closed
Closed
Closed
@balazsorban44
Copy link
Member

Since these are just general typo fixes, you don't need to group them into anything specific.

balazsorban44
balazsorban44 previously requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address #56788 (comment) then we can merge this. Thanks! 💚

@suravshrestha
Copy link
Contributor Author

Let's address #56788 (comment) then we can merge this. Thanks! 💚

@balazsorban44, I've included the changes from those PRs in this one. Could you please review and merge? Thank you!

@styfle styfle added CI approved Approve running CI for fork and removed examples Issue/PR related to examples labels Oct 13, 2023
@styfle styfle changed the title docs: fix typo in examples/with-supabase/README.md docs: fix several typos Oct 13, 2023
@styfle styfle dismissed balazsorban44’s stale review October 13, 2023 19:39

changes are addressed

@styfle styfle merged commit 869d93c into vercel:canary Oct 13, 2023
54 checks passed
@github-actions github-actions bot added the locked label Nov 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit is a code owner automatically assigned from vercel/devex

@molebox molebox Awaiting requested review from molebox molebox is a code owner automatically assigned from vercel/devex

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
CI approved Approve running CI for fork locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suravshrestha @timneutkens @balazsorban44 @styfle @ijjk