Fix @next/mdx types #57580
Merged
Fix @next/mdx types #57580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s not possible to combine `export =` type definitions with ESM-style exports. To export types for a module that uses `module.exports =`, one needs to use a namespace. Also `Options` is now imported from `@mdx-js/loader`. The imports need to come from a direct dependency or peer dependency. Also `@mdx-js/loader` is more accurate here, because the options are passed into `@mdx-js/loader`.
remcohaszing
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
ztanner and
wyattjoh
as code owners
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
I could also convert |
|
@timneutkens I’m pinging a random reviewer. This PR fixes a syntax error, which I consider to be a fairly severe bug, but it has been open for over 3 months. |
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
|
|
The CI failure appears to be unrelated. |
ijjk
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s not possible to combine
export =type definitions with ESM-style exports. To export types for a module that usesmodule.exports =, one needs to use a namespace.Also
Optionsis now imported from@mdx-js/loader. The imports need to come from a direct dependency or peer dependency. Also@mdx-js/loaderis more accurate here, because the options are passed into@mdx-js/loader.