Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix encoding for filenames containing ? or # #58293

Merged
merged 34 commits into from
Apr 5, 2024
Merged

fix encoding for filenames containing ? or # #58293

merged 34 commits into from
Apr 5, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 10, 2023 •
edited by padmaia

Closes PACK-1935

@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Nov 10, 2023
@ijjk
Copy link
Member

ijjk commented Nov 10, 2023 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/improve-escape Change
buildDuration 14.8s 14.8s N/A
buildDurationCached 9.3s 6.7s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +12.1 kB
nextStartRea..uration (ms) 426ms 411ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/improve-escape Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 243 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/improve-escape Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sokra/improve-escape Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/improve-escape Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/improve-escape Change
index.html gzip 529 B 529 B ✓
link.html gzip 541 B 541 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.59 kB 1.59 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/improve-escape Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sokra/improve-escape Change
middleware-b..fest.js gzip 625 B 623 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sokra/improve-escape Change
app-page-exp...dev.js gzip 170 kB 170 kB N/A
app-page-exp..prod.js gzip 97 kB 97 kB N/A
app-page-tur..prod.js gzip 98.8 kB 98.8 kB N/A
app-page-tur..prod.js gzip 93 kB 93 kB N/A
app-page.run...dev.js gzip 144 kB 144 kB N/A
app-page.run..prod.js gzip 91.5 kB 91.5 kB N/A
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 15.2 kB 15.2 kB ✓
app-route-tu..prod.js gzip 14.9 kB 14.9 kB ✓
app-route.ru...dev.js gzip 21.1 kB 21.1 kB ✓
app-route.ru..prod.js gzip 14.9 kB 14.9 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 51.1 kB 51.1 kB ✓
Overall change 251 kB 251 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/improve-escape Change
0.pack gzip 1.58 MB 1.58 MB ⚠️ +1.91 kB
index.pack gzip 106 kB 106 kB N/A
Overall change 1.58 MB 1.58 MB ⚠️ +1.91 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 50a4bc6

timneutkens
timneutkens previously requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this change needs a test.

@ijjk
Copy link
Member

ijjk commented Nov 10, 2023 •
edited

Tests Passed

@sokra sokra requested a review from a team as a code owner November 10, 2023 15:11
@sokra sokra marked this pull request as draft January 15, 2024 08:03
@ijjk ijjk added area: tests Turbopack Related to Turbopack with Next.js. labels Mar 25, 2024
@wbinnssmith wbinnssmith marked this pull request as draft March 28, 2024 22:30
@wbinnssmith wbinnssmith marked this pull request as ready for review April 5, 2024 17:25
@wbinnssmith wbinnssmith merged commit f6baf61 into canary Apr 5, 2024
78 checks passed
@wbinnssmith wbinnssmith deleted the sokra/improve-escape branch April 5, 2024 17:25
wbinnssmith added a commit that referenced this pull request Apr 5, 2024
@wbinnssmith
Escape url-unsafe characters in names of app router scripts and styles
436e087 
Building on #58293, this expands escaping of url-unsafe characters in paths to “required” scripts and styles in the app renderer.

This also refactors the test introduced in #58293 and expands it to include stylesheet references as well as checking resources in the head, which include special characters like turbopack references like `[turbopack]`.

Test Plan: `TURBOPACK=1 pnpm test-dev test/e2e/app-dir/resource-url-encoding`
@wbinnssmith wbinnssmith mentioned this pull request Apr 5, 2024
Merged
wbinnssmith added a commit that referenced this pull request Apr 11, 2024
@wbinnssmith
Escape url-unsafe characters in names of app router scripts and styles (
11575a4 
#64131)

Building on #58293, this expands escaping of url-unsafe characters in
paths to “required” scripts and styles in the app renderer.
    
This also refactors the test introduced in #58293 and expands it to
include stylesheet references as well as checking resources in the head,
which include special characters like turbopack references like
`[turbopack]`.
    
Test Plan: `TURBOPACK=1 pnpm test-dev
test/e2e/app-dir/resource-url-encoding`

Closes PACK-2911
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@lubieowoce lubieowoce lubieowoce approved these changes

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sokra @ijjk @wbinnssmith @timneutkens @lubieowoce