Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Do not mangle AbortSignal to avoid breaking node-fetch #58534

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat: Do not mangle AbortSignal to avoid breaking node-fetch #58534

merged 5 commits into from
Apr 9, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 16, 2023 •
edited by padmaia

What?

Add AbortSignal to the reserved list of the name mangler.

Why?

We don't want node-fetch to throw an exception.

x-ref: https://vercel.slack.com/archives/C04KC8A53T7/p1700123182211619?thread_ts=1700090771.304599&cid=C04KC8A53T7

How?

This PR modifies the mangle option from the Rust side code.

Closes PACK-1977

@kdy1 kdy1 self-assigned this Nov 16, 2023
@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Nov 16, 2023
@kdy1 kdy1 changed the title fix: feat: Do not mangle AbortSignal to avoid breaking node-fetch Nov 16, 2023
@ijjk
Copy link
Member

ijjk commented Nov 16, 2023 •
edited

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
buildDuration 13.7s 13.9s ⚠️ +161ms
buildDurationCached 7.5s 6.2s N/A
nodeModulesSize 198 MB 198 MB ⚠️ +418 B
nextStartRea..uration (ms) 403ms 401ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
2453-HASH.js gzip 31 kB 31 kB N/A
3304.HASH.js gzip 181 B 181 B ✓
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB ✓
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 242 B 242 B ✓
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B ✓
amp-HASH.js gzip 505 B 505 B ✓
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B ✓
head-HASH.js gzip 352 B 352 B ✓
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 6.57 kB 6.57 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 541 B ✓
withRouter.html gzip 524 B 524 B ✓
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
middleware-b..fest.js gzip 627 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B ✓
Overall change 990 B 990 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
app-page-exp...dev.js gzip 170 kB 170 kB ✓
app-page-exp..prod.js gzip 97 kB 97 kB ✓
app-page-tur..prod.js gzip 98.7 kB 98.7 kB ✓
app-page-tur..prod.js gzip 93 kB 93 kB ✓
app-page.run...dev.js gzip 144 kB 144 kB ✓
app-page.run..prod.js gzip 91.5 kB 91.5 kB ✓
app-route-ex...dev.js gzip 21.4 kB 21.4 kB ✓
app-route-ex..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 15.1 kB 15.1 kB ✓
app-route-tu..prod.js gzip 14.8 kB 14.8 kB ✓
app-route.ru...dev.js gzip 21 kB 21 kB ✓
app-route.ru..prod.js gzip 14.8 kB 14.8 kB ✓
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB ✓
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB ✓
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB ✓
pages-turbo...prod.js gzip 22.5 kB 22.5 kB ✓
pages.runtim...dev.js gzip 23.1 kB 23.1 kB ✓
pages.runtim..prod.js gzip 22.4 kB 22.4 kB ✓
server.runti..prod.js gzip 51 kB 51 kB ✓
Overall change 944 kB 944 kB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/mangle-reserved Change
0.pack gzip 1.57 MB 1.57 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +216 B
Overall change 105 kB 106 kB ⚠️ +216 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: db1e984

@kdy1 kdy1 marked this pull request as ready for review November 16, 2023 11:30
@ijjk
Copy link
Member

ijjk commented Nov 17, 2023 •
edited

Tests Passed

sokra
sokra reviewed Nov 17, 2023
View reviewed changes
packages/next-swc/crates/napi/src/minify.rs
@@ -109,6 +112,10 @@ fn patch_opts(opts: &mut JsMinifyOptions) {
inline: Some(TerserInlineOption::Num(2)),
..Default::default()
});
opts.mangle = BoolOrDataConfig::from_obj(MangleOptions {
reserved: vec!["AbortSignal".into()],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also put it in the reserved list for terser options?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, will do

@feedthejim
Copy link
Contributor

Could we perhaps add a test to avoid a regression there?

@kdy1
Copy link
Member Author

kdy1 commented Nov 20, 2023

Do you know how I can add a test for server minification? Will adding an API route and using node-fetch from there work?

@kdy1 kdy1 marked this pull request as draft January 23, 2024 02:45
@kdy1 kdy1 marked this pull request as ready for review March 26, 2024 04:05
@kdy1 kdy1 requested a review from wyattjoh as a code owner March 26, 2024 04:05
@kdy1 kdy1 requested a review from sokra March 26, 2024 04:05
@kdy1 kdy1 merged commit 5aa984d into canary Apr 9, 2024
76 of 77 checks passed
@kdy1 kdy1 deleted the kdy1/mangle-reserved branch April 9, 2024 00:28
@kdy1 kdy1 mentioned this pull request Apr 9, 2024
Merged
kdy1 added a commit that referenced this pull request Apr 9, 2024
@kdy1
chore: Fix CI (#64233)
9638b9d 
### What?

Fix CI, which is broken due to #58534

### Why?

The PR was out of sync and CI didn't check turbo build

### How?


Closes PACK-2920
@ijjk ijjk mentioned this pull request Apr 9, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the turbopack team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kdy1 @ijjk @feedthejim @sokra