Add maxDuration to typescript plugin allowed exports

[AhmedBaset]

According to docs and tests. maxDuration should be a valid export. currently TypeScript plugin throws.

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: a8d0179

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[ijjk]

Allow CI Workflow Run

• approve CI run for commit: 29ec827

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

[lilianchisca]

@A7med3bdulBaset mate you closed this one, but I still have that issue... I use export const maxDuration in some of the app page.tsx files where I needed that maxDuration higher, and vercel picks it up... but I'm still getting that typescript error that it's not a const that can be exported for those files.

[AhmedBaset]

I thought #55918 that was merged in 14.0.4 addresses this. I just double-checked, It doesn't resolve the TS plugin

reopening...

[RJWadley]

fixes #59753

@A7med3bdulBaset you should also add a hint and a validator for this, similar to the one revalidate has earlier in the file:

    isValid: (value: string) => {
      return Number(value.replace(/_/g, '')) > 0
    },
    getHint: (value: any) => {
      return `Limits execution time to \`${value}\` seconds.`
    },

[qoobes]

What's blocking this in the end? I'm still getting the error.

[ijjk]

Failing test suites

Commit: 50a1a3d

pnpm test test/unit/web-runtime/next-response.test.ts

• can be cloned

Expand output

● can be cloned

TypeError: fetch failed

  at Object.processResponse (eval at requireWithFakeGlobalScope (../node_modules/.pnpm/@edge-runtime+primitives@4.0.2/node_modules/@edge-runtime/primitives/dist/load.js:65:3), <anonymous>:11454:27)
  at eval (eval at requireWithFakeGlobalScope (../node_modules/.pnpm/@edge-runtime+primitives@4.0.2/node_modules/@edge-runtime/primitives/dist/load.js:65:3), <anonymous>:11791:42)

Cause:
ConnectTimeoutError: Connect Timeout Error

  at onConnectTimeout (eval at requireWithFakeGlobalScope (../node_modules/.pnpm/@edge-runtime+primitives@4.0.2/node_modules/@edge-runtime/primitives/dist/load.js:65:3), <anonymous>:9145:28)
  at eval (eval at requireWithFakeGlobalScope (../node_modules/.pnpm/@edge-runtime+primitives@4.0.2/node_modules/@edge-runtime/primitives/dist/load.js:65:3), <anonymous>:9101:50)
  at Immediate.eval [as _onImmediate] (eval at requireWithFakeGlobalScope (../node_modules/.pnpm/@edge-runtime+primitives@4.0.2/node_modules/@edge-runtime/primitives/dist/load.js:65:3), <anonymous>:9133:13)

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
buildDuration	11.8s	11.8s	N/A
buildDurationCached	6s	4.9s	N/A
nodeModulesSize	200 MB	200 MB	⚠️ +1.53 kB
nextStartRea..uration (ms)	428ms	435ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
3f784ff6-HASH.js gzip	53.4 kB	53.4 kB	✓
423.HASH.js gzip	185 B	181 B	N/A
68-HASH.js gzip	29.8 kB	29.8 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	238 B	239 B	N/A
main-HASH.js gzip	31.8 kB	31.8 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	100 kB	100 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	182 B	181 B	N/A
amp-HASH.js gzip	502 B	502 B	✓
css-HASH.js gzip	320 B	322 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	255 B	256 B	N/A
head-HASH.js gzip	350 B	349 B	N/A
hooks-HASH.js gzip	368 B	369 B	N/A
image-HASH.js gzip	4.18 kB	4.18 kB	N/A
index-HASH.js gzip	257 B	256 B	N/A
link-HASH.js gzip	2.61 kB	2.61 kB	N/A
routerDirect..HASH.js gzip	310 B	311 B	N/A
script-HASH.js gzip	384 B	383 B	N/A
withRouter-HASH.js gzip	306 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	608 B	608 B	✓

Client Build Manifests

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
_buildManifest.js gzip	484 B	484 B	✓
Overall change	484 B	484 B	✓

Rendered Page Sizes

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
index.html gzip	528 B	527 B	N/A
link.html gzip	541 B	540 B	N/A
withRouter.html gzip	523 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
edge-ssr.js gzip	94 kB	94 kB	N/A
page.js gzip	149 kB	149 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
middleware-b..fest.js gzip	624 B	621 B	N/A
middleware-r..fest.js gzip	151 B	149 B	N/A
middleware.js gzip	37.6 kB	37.6 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Next Runtimes

	vercel/next.js canary	A7med3bdulBaset/next.js patch-8	Change
app-page-exp...dev.js gzip	170 kB	170 kB	✓
app-page-exp..prod.js gzip	95.6 kB	95.6 kB	✓
app-page-tur..prod.js gzip	96.3 kB	96.3 kB	✓
app-page-tur..prod.js gzip	90.9 kB	90.9 kB	✓
app-page.run...dev.js gzip	142 kB	142 kB	✓
app-page.run..prod.js gzip	90.2 kB	90.2 kB	✓
app-route-ex...dev.js gzip	22.2 kB	22.2 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.5 kB	14.5 kB	✓
app-route.ru...dev.js gzip	21.6 kB	21.6 kB	✓
app-route.ru..prod.js gzip	14.5 kB	14.5 kB	✓
pages-api-tu..prod.js gzip	9.42 kB	9.42 kB	✓
pages-api.ru...dev.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru..prod.js gzip	9.42 kB	9.42 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	22.6 kB	22.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	49.7 kB	49.7 kB	✓
Overall change	932 kB	932 kB	✓

Commit: a1f5648