Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Error Fetching _devpagesmanifest.json #17274 #60349

Merged
merged 11 commits into from
Feb 6, 2024

Conversation

itz-Me-Pj
Copy link
Contributor

Closes NEXT-
Fixes #17274 Error Fetching _devpagesmanfest.json

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this PR, can you make sure a test is included that verifies what is described in the issue. Thanks!

@itz-Me-Pj
Copy link
Contributor Author

Hey, thanks for this PR, can you make sure a test is included that verifies what is described in the issue. Thanks!

Hi @timneutkens I can but can you provide a reference on how can I test this change or some other test I can refer to? As I am still exploring this project.

@timneutkens
Copy link
Member

There's a guide for testing available here: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md

@itz-Me-Pj
Copy link
Contributor Author

@timneutkens Added tests for the changes. Sorry it took a while. Feel free to mention if more changes are required

@itz-Me-Pj
Copy link
Contributor Author

hi @timneutkens any update on this PR?

@itz-Me-Pj
Copy link
Contributor Author

@ijjk added all the changes requested

@ijjk
Copy link
Member

ijjk commented Feb 6, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
buildDuration 11s 10.8s N/A
buildDurationCached 6.1s 5.1s N/A
nodeModulesSize 318 MB 318 MB ⚠️ +1.19 kB
nextStartRea..uration (ms) 426ms 431ms N/A
Client Bundles (main, webpack)
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.7 kB 29.7 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 501 B N/A
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.22 kB 4.21 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 106 B 106 B
Client Build Manifests
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
index.html gzip 528 B 527 B N/A
link.html gzip 539 B 537 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 47.4 kB 47.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 1.94 kB 1.94 kB
Next Runtimes
vercel/next.js canary itz-Me-Pj/next.js sameOriginFix Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.1 kB 95.1 kB
app-page-tur..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 91.5 kB 91.5 kB
app-page.run...dev.js gzip 135 kB 135 kB
app-page.run..prod.js gzip 90 kB 90 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 922 kB 922 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: f553b90

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk added the CI approved Approve running CI for fork label Feb 6, 2024
@ijjk ijjk merged commit 98232c8 into vercel:canary Feb 6, 2024
62 of 67 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching _devPagesManifest.json
3 participants