Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace micromatch w/ picomatch #60699

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jan 16, 2024

The PR continues from #58038 aiming to reduce the installation size further, and improve performance in doing so.

Most of micromatch's APIs are essentially wrappers/alias of picomatch, supplemented with additional features facilitated by a transitive dependency braces. However, Next.js doesn't use those "extra features". Switching from micromatch to picomatch can avoid introducing the transitive dependency braces.

The PR also improves some globs' performance by hoisting.

@ijjk
Copy link
Member

ijjk commented Jan 16, 2024

Stats from current PR

Default Build
General
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
buildDuration 11.9s 11.4s N/A
buildDurationCached 6.1s 4.9s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 429ms 431ms N/A
Client Bundles (main, webpack)
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
433-HASH.js gzip 29 kB 29 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 243 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
index.html gzip 528 B 528 B
link.html gzip 540 B 540 B
withRouter.html gzip 523 B 523 B
Overall change 1.59 kB 1.59 kB
Edge SSR bundle Size
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
middleware-b..fest.js gzip 623 B 626 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary SukkaW/next.js replace-micromatch-with-picomatch Change
app-page-exp...dev.js gzip 169 kB 169 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.9 kB 90.9 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 24.2 kB 24.2 kB
app-route-ex..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.9 kB 16.9 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route.ru...dev.js gzip 23.6 kB 23.6 kB
app-route.ru..prod.js gzip 16.4 kB 16.4 kB
pages-api-tu..prod.js gzip 9.41 kB 9.41 kB
pages-api.ru...dev.js gzip 9.68 kB 9.68 kB
pages-api.ru..prod.js gzip 9.4 kB 9.4 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 944 kB 944 kB
Commit: 41f867d

@SukkaW SukkaW force-pushed the replace-micromatch-with-picomatch branch from b45b016 to d755a4d Compare January 19, 2024 03:22
Copy link

socket-security bot commented Jan 19, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/picomatch@2.3.3 None 0 18 kB types
npm/picomatch@3.0.1 None 0 85.3 kB jonschlinkert

🚮 Removed packages: npm/@types/micromatch@4.0.2

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Jan 19, 2024

Failing test suites

Commit: d755a4d

pnpm test-dev test/e2e/middleware-trailing-slash/test/index.test.ts (PPR)

  • Middleware Runtime trailing slash > should have init header for NextResponse.redirect
Expand output

● Middleware Runtime trailing slash › should have init header for NextResponse.redirect

expect(received).toBe(expected) // Object.is equality

Expected: 307
Received: 500

  166 |         }
  167 |       )
> 168 |       expect(res.status).toBe(307)
      |                          ^
  169 |       expect(new URL(res.headers.get('location'), 'http://n').pathname).toBe(
  170 |         '/somewhere/'
  171 |       )

  at Object.toBe (e2e/middleware-trailing-slash/test/index.test.ts:168:26)

Read more about building and testing Next.js in contributing.md.

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a :pr:!

:lgtm:

@samcx samcx enabled auto-merge (squash) January 19, 2024 19:33
@samcx samcx merged commit 53a0a0f into vercel:canary Jan 19, 2024
67 checks passed
@github-actions github-actions bot added the locked label Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants