Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turbopack: rename custom cache handler configs #60828

Merged
merged 3 commits into from Jan 18, 2024
Merged

turbopack: rename custom cache handler configs #60828

merged 3 commits into from Jan 18, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 18, 2024 •
edited by padmaia

Follow up for #57953 for turbopack side

Closes NEXT-2153

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Next.js team PRs by the Next.js team type: next labels Jan 18, 2024
@ijjk
Copy link
Member

ijjk commented Jan 18, 2024 •
edited

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
buildDuration 12.8s 12.9s N/A
buildDurationCached 7s 6.2s N/A
nodeModulesSize 200 MB 200 MB ✓
nextStartRea..uration (ms) 428ms 430ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB ✓
433-HASH.js gzip 29 kB 29 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB ✓
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B ✓
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB ✓
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.4 kB 3.4 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
index.html gzip 528 B 526 B N/A
link.html gzip 540 B 539 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
edge-ssr.js gzip 93.9 kB 93.9 kB N/A
page.js gzip 148 kB 148 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B ✓
middleware.js gzip 37.5 kB 37.5 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB ✓
Overall change 2.07 kB 2.07 kB ✓
Next Runtimes
vercel/next.js canary vercel/next.js turbopack/rename-cache-handler-configs Change
app-page-exp...dev.js gzip 169 kB 169 kB ✓
app-page-exp..prod.js gzip 95.6 kB 95.6 kB ✓
app-page-tur..prod.js gzip 96.3 kB 96.3 kB ✓
app-page-tur..prod.js gzip 90.8 kB 90.8 kB ✓
app-page.run...dev.js gzip 142 kB 142 kB ✓
app-page.run..prod.js gzip 90.2 kB 90.2 kB ✓
app-route-ex...dev.js gzip 24.2 kB 24.2 kB ✓
app-route-ex..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.8 kB 16.8 kB ✓
app-route-tu..prod.js gzip 16.4 kB 16.4 kB ✓
app-route.ru...dev.js gzip 23.6 kB 23.6 kB ✓
app-route.ru..prod.js gzip 16.4 kB 16.4 kB ✓
pages-api-tu..prod.js gzip 9.39 kB 9.39 kB ✓
pages-api.ru...dev.js gzip 9.67 kB 9.67 kB ✓
pages-api.ru..prod.js gzip 9.39 kB 9.39 kB ✓
pages-turbo...prod.js gzip 22 kB 22 kB ✓
pages.runtim...dev.js gzip 22.6 kB 22.6 kB ✓
pages.runtim..prod.js gzip 22 kB 22 kB ✓
server.runti..prod.js gzip 49.7 kB 49.7 kB ✓
Overall change 943 kB 943 kB ✓
Commit: 346e502

@huozhi huozhi marked this pull request as ready for review January 18, 2024 16:35
@huozhi huozhi requested review from timneutkens, ijjk, shuding and a team as code owners January 18, 2024 16:35
ijjk
ijjk reviewed Jan 18, 2024
View reviewed changes
packages/next-swc/crates/next-core/src/next_config.rs
/// In-memory cache size in bytes.
///
/// If `isr_memory_cache_size: 0` disables in-memory caching.
pub isr_memory_cache_size: Option<f64>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we leave a warning when the experimental configs are used still?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add later in a different one

@huozhi huozhi mentioned this pull request Jan 18, 2024
Merged
@ForsakenHarmony ForsakenHarmony merged commit c192f4e into canary Jan 18, 2024
67 checks passed
@ForsakenHarmony ForsakenHarmony deleted the turbopack/rename-cache-handler-configs branch January 18, 2024 17:10
huozhi added a commit that referenced this pull request Jan 18, 2024
@huozhi
dx: warn the deprecated cache configs are used (#60836)
b8d8e6e 
Follow up for #57953 for DX, give better warnings

x-ref:
#60828 (comment)

Closes NEXT-2156
@drewkhoury drewkhoury mentioned this pull request Jan 18, 2024
Open
This was referenced Jan 19, 2024
Open
Open
@YUTONG773 YUTONG773 mentioned this pull request Jan 19, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 19, 2024
Open
@gitworkflows gitworkflows mentioned this pull request Jan 19, 2024
Open
@nicholasklem nicholasklem mentioned this pull request Jan 19, 2024
Open
@Abuchtela Abuchtela mentioned this pull request Jan 19, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 19, 2024
Open
@Abuchtela Abuchtela mentioned this pull request Jan 19, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 19, 2024
Open
This was referenced Jan 19, 2024
Open
Open
@gabidobo gabidobo mentioned this pull request Jan 19, 2024
Open
@adamlaska adamlaska mentioned this pull request Jan 20, 2024
Open
@nicholasklem nicholasklem mentioned this pull request Jan 20, 2024
Open
@vordgi vordgi mentioned this pull request Jan 21, 2024
Open
@github-actions github-actions bot added the locked label Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huozhi @ijjk @ForsakenHarmony