Implement client_root for edge in Turbopack #61024
Merged
+205
−152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
a team,
styfle and
ztanner
as code owners
timneutkens
requested review from
timeyoutakeit and
StephDietz
and removed request for
a team
ijjk
added
area: tests
Turbopack
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on |
timneutkens
force-pushed
the
01-23-Implement_client_root_for_edge_in_Turbopack
branch
from
9e8fcd1
to
e58a2b0
Compare
timneutkens
commented
Jan 23, 2024
Tests Passed |
timneutkens
requested review from
a team,
feedthejim and
wyattjoh
as code owners
timneutkens
deleted the
01-23-Implement_client_root_for_edge_in_Turbopack
branch
|
Landing as Tobias reviewed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implements vercel/turbo#7081. Ensures image imports in the edge runtime have the correct asset url. Previously it would be
/assets/file.hash.pngbut it should be/_next/static/media/file.hash.png.Updates the image tests to correctly compare the values in Turbopack and the values in Webpack. Currently it only checks webpack values, causing the tests to fail in Turbopack.
Closes NEXT-2194