Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update terser to v5.27.0 #61068

Merged
merged 8 commits into from
Jan 24, 2024
Merged

chore: Update terser to v5.27.0 #61068

merged 8 commits into from
Jan 24, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 24, 2024

What?

Update terser to the latest version.

Why?

We need terser/terser@c677e28 which adds supports for class static blocks.

How?

Closes PACK-2285
Fixes #60837

@kdy1 kdy1 self-assigned this Jan 24, 2024
Copy link

socket-security bot commented Jan 24, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/terser@5.27.0 environment, eval Transitive: filesystem, shell +10 3.67 MB fabiosantoscode

🚮 Removed packages: npm/terser@5.14.1

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
buildDuration 11.7s 11.8s ⚠️ +107ms
buildDurationCached 6.1s 5s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +50.5 kB
nextStartRea..uration (ms) 434ms 433ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
411-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.6 kB 98.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
polyfills-HASH.js gzip 31 kB 31 kB N/A
Overall change 0 B 0 B
Client Pages
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
_buildManifest.js gzip 484 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 539 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
middleware-b..fest.js gzip 624 B 627 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/pack-2285 Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.6 kB 95.6 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.9 kB 90.9 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.6 kB 21.6 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.41 kB 9.41 kB
pages-api.ru...dev.js gzip 9.68 kB 9.68 kB
pages-api.ru..prod.js gzip 9.4 kB 9.4 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 932 kB 932 kB
Diff details
Diff for polyfills-HASH.js

Diff too large to display

Commit: c1b98fc

@ijjk
Copy link
Member

ijjk commented Jan 24, 2024

Failing test suites

Commit: c1b98fc

TURBOPACK=1 pnpm test-dev test/development/acceptance-app/rsc-build-errors.test.ts (turbopack)

  • Error overlay - RSC build errors > should contain nextjs version check in error overlay
Expand output

● Error overlay - RSC build errors › should contain nextjs version check in error overlay

page.waitForLoadState: Timeout 60000ms exceeded.

  447 |         })
  448 |         .then(async (val) => {
> 449 |           await page.waitForLoadState()
      |                      ^
  450 |           return val as T
  451 |         })
  452 |     )

  at waitForLoadState (lib/browsers/playwright.ts:449:22)
  at lib/browsers/base.ts:45:19

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 marked this pull request as ready for review January 24, 2024 06:24
@kdy1 kdy1 changed the title chore: Update terser chore: Update terser to v5.27.0 Jan 24, 2024
@sokra sokra merged commit ccf491d into canary Jan 24, 2024
65 of 68 checks passed
@sokra sokra deleted the kdy1/pack-2285 branch January 24, 2024 07:42
@github-actions github-actions bot added the locked label Feb 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Error: Unexpected token: punc ({)
4 participants