Update `swc_core` to `v0.89.x` #61086

kdy1 · 2024-01-24T13:35:34Z

Turbopack

Update swc_core to v0.89.x turbo#7092

What?

Update SWC crates

Why?

To fix some issues

How?

Fixes #59805
Fixes #56144

Closes PACK-2222
Closes PACK-2285

ijjk · 2024-01-25T10:24:07Z

Stats from current PR

Default Build

General

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
buildDuration	11.7s	11.8s	N/A
buildDurationCached	6.2s	4.9s	N/A
nodeModulesSize	200 MB	200 MB	✓
nextStartRea..uration (ms)	427ms	435ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
3f784ff6-HASH.js gzip	53.4 kB	53.4 kB	✓
423.HASH.js gzip	185 B	181 B	N/A
68-HASH.js gzip	29.8 kB	29.8 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	238 B	240 B	N/A
main-HASH.js gzip	31.8 kB	31.8 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	✓
Overall change	100 kB	100 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	182 B	181 B	N/A
amp-HASH.js gzip	502 B	502 B	✓
css-HASH.js gzip	320 B	322 B	N/A
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	255 B	256 B	N/A
head-HASH.js gzip	350 B	349 B	N/A
hooks-HASH.js gzip	368 B	369 B	N/A
image-HASH.js gzip	4.18 kB	4.18 kB	N/A
index-HASH.js gzip	257 B	256 B	N/A
link-HASH.js gzip	2.61 kB	2.61 kB	N/A
routerDirect..HASH.js gzip	310 B	311 B	N/A
script-HASH.js gzip	384 B	383 B	N/A
withRouter-HASH.js gzip	306 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	608 B	608 B	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
_buildManifest.js gzip	484 B	484 B	✓
Overall change	484 B	484 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
index.html gzip	528 B	527 B	N/A
link.html gzip	541 B	540 B	N/A
withRouter.html gzip	523 B	522 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
edge-ssr.js gzip	94 kB	94 kB	N/A
page.js gzip	149 kB	149 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
middleware-b..fest.js gzip	626 B	622 B	N/A
middleware-r..fest.js gzip	151 B	149 B	N/A
middleware.js gzip	37.6 kB	37.6 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	1.92 kB	1.92 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js kdy1/swc-core-89-1	Change
app-page-exp...dev.js gzip	170 kB	170 kB	✓
app-page-exp..prod.js gzip	95.7 kB	95.7 kB	✓
app-page-tur..prod.js gzip	96.4 kB	96.4 kB	✓
app-page-tur..prod.js gzip	90.9 kB	90.9 kB	✓
app-page.run...dev.js gzip	142 kB	142 kB	✓
app-page.run..prod.js gzip	90.3 kB	90.3 kB	✓
app-route-ex...dev.js gzip	22.2 kB	22.2 kB	✓
app-route-ex..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.9 kB	14.9 kB	✓
app-route-tu..prod.js gzip	14.5 kB	14.5 kB	✓
app-route.ru...dev.js gzip	21.6 kB	21.6 kB	✓
app-route.ru..prod.js gzip	14.5 kB	14.5 kB	✓
pages-api-tu..prod.js gzip	9.42 kB	9.42 kB	✓
pages-api.ru...dev.js gzip	9.69 kB	9.69 kB	✓
pages-api.ru..prod.js gzip	9.42 kB	9.42 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	22.6 kB	22.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	49.7 kB	49.7 kB	✓
Overall change	933 kB	933 kB	✓

Commit: bc4c696

ijjk · 2024-01-25T10:26:17Z

Tests Passed

kdy1 · 2024-01-26T04:59:20Z

Regression commit range:

swc: swc-project/swc@6d9939d...1890e66
~~swc plugins: https://github.com/swc-project/plugins/compare/b42da8316c8db0244fcfa61f255c54748ced9f16..main~~
next.js: 014b212...canary
turbo: vercel/turbo@53fa9b4...main

kdy1 · 2024-01-26T10:15:35Z

Investigation

4eaa68e + vercel/turbo@f63cc49 fails
9b32a5f + vercel/turbo@d4aa14d fails

kdy1 · 2024-01-27T04:02:36Z

swc-project/swc#8530 was the cause of the regression

kdy1 · 2024-01-27T04:07:46Z

packages/next-swc/crates/next-custom-transforms/src/transforms/react_server_components.rs

@@ -642,7 +642,10 @@ pub fn server_components<C: Comments>(
    as_folder(ReactServerComponents {
        is_react_server_layer,
        comments,
-        filepath: filename.to_string(),
+        filepath: match filename {
+            FileName::Custom(path) => format!("<{}>", path),


This is to partially revert swc-project/swc#8530

### Description Update SWC crates. ### Testing Instructions - next.js counterpart: vercel/next.js#61086 Closes PACK-2286

kdy1 self-assigned this Jan 24, 2024

ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Jan 24, 2024

kdy1 mentioned this pull request Jan 24, 2024

Update swc_core to v0.89.x vercel/turbo#7092

Merged

kdy1 force-pushed the kdy1/swc-core-89-1 branch from 1d1111f to d050e8c Compare January 25, 2024 10:07

ijjk added the Font (next/font) Related to Next.js Font Optimization. label Jan 25, 2024

kdy1 force-pushed the kdy1/swc-core-89-1 branch 2 times, most recently from 029f69e to 458ee0c Compare January 26, 2024 02:59

kdy1 mentioned this pull request Jan 26, 2024

[DO NOT MERGE] Check CI #61182

Closed

kdy1 force-pushed the kdy1/swc-core-89-1 branch 3 times, most recently from 790d0a7 to 4eaa68e Compare January 26, 2024 09:59

kdy1 force-pushed the kdy1/swc-core-89-1 branch from 4eaa68e to 9b32a5f Compare January 26, 2024 10:22

kdy1 mentioned this pull request Jan 27, 2024

Document compiling nested CSS classes in styled-jsx swc-project/swc#8564

Open

kdy1 added 8 commits January 27, 2024 13:05

Update swc_core

3934d83

cargo lockfile

4dfa44f

log on failure

0d5c35b

Update swc_core

9e580c3

cargo lockfile

bf6b98e

import phase

4c2fd8b

link next.js

e81b73e

Partially revert swc-project/swc#8530

119f955

kdy1 force-pushed the kdy1/swc-core-89-1 branch from a28671a to 119f955 Compare January 27, 2024 04:06

kdy1 commented Jan 27, 2024

View reviewed changes

sokra approved these changes Jan 27, 2024

View reviewed changes

kdy1 added a commit to vercel/turbo that referenced this pull request Jan 27, 2024

Update swc_core to v0.89.x (#7092)

a9b7872

### Description Update SWC crates. ### Testing Instructions - next.js counterpart: vercel/next.js#61086 Closes PACK-2286

link next.js

8f91704

kdy1 marked this pull request as ready for review January 27, 2024 09:26

kdy1 requested review from timneutkens, ijjk, shuding, huozhi, a team, feedthejim, ztanner and wyattjoh as code owners January 27, 2024 09:26

Merge branch 'canary' into kdy1/swc-core-89-1

bc4c696

kdy1 enabled auto-merge (squash) January 27, 2024 09:26

kdy1 merged commit 7b9d90b into canary Jan 27, 2024
66 of 68 checks passed

kdy1 deleted the kdy1/swc-core-89-1 branch January 27, 2024 09:43

github-actions bot added the locked label Feb 10, 2024

github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `swc_core` to `v0.89.x` #61086

Update `swc_core` to `v0.89.x` #61086

kdy1 commented Jan 24, 2024 •

edited

ijjk commented Jan 25, 2024 •

edited

ijjk commented Jan 25, 2024 •

edited

kdy1 commented Jan 26, 2024 •

edited

kdy1 commented Jan 26, 2024 •

edited

kdy1 commented Jan 27, 2024

kdy1 Jan 27, 2024

Update swc_core to v0.89.x #61086

Update swc_core to v0.89.x #61086

Conversation

kdy1 commented Jan 24, 2024 • edited

Turbopack

What?

Why?

How?

ijjk commented Jan 25, 2024 • edited

Stats from current PR

ijjk commented Jan 25, 2024 • edited

Tests Passed

kdy1 commented Jan 26, 2024 • edited

kdy1 commented Jan 26, 2024 • edited

Investigation

kdy1 commented Jan 27, 2024

kdy1 Jan 27, 2024

Choose a reason for hiding this comment

Update `swc_core` to `v0.89.x` #61086

Update `swc_core` to `v0.89.x` #61086

kdy1 commented Jan 24, 2024 •

edited

ijjk commented Jan 25, 2024 •

edited

ijjk commented Jan 25, 2024 •

edited

kdy1 commented Jan 26, 2024 •

edited

kdy1 commented Jan 26, 2024 •

edited