-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update turbopack #61090
Merged
ForsakenHarmony
merged 1 commit into
canary
from
hrmny/pack-2282-turbopack-assetprefix-fix
Jan 24, 2024
Merged
chore: update turbopack #61090
ForsakenHarmony
merged 1 commit into
canary
from
hrmny/pack-2282-turbopack-assetprefix-fix
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
ForsakenHarmony
force-pushed
the
hrmny/pack-2282-turbopack-assetprefix-fix
branch
from
January 24, 2024 16:42
97bec22
to
6d7af49
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ForsakenHarmony and the rest of your teammates on Graphite |
ForsakenHarmony
added a commit
to vercel/turbo
that referenced
this pull request
Jan 24, 2024
…7093) ### Description next's asset prefix can be a full URL, I think we can assume that the basepath itself is valid. we probably also want to ensure that the `chunkPath` never contains invalid URL characters at build time so we don't need to escape anything at all at runtime. Need to make sure it passes all next.js tests vercel/next.js#61090 Closes PACK-2282
ForsakenHarmony
force-pushed
the
hrmny/pack-2282-turbopack-assetprefix-fix
branch
from
January 24, 2024 20:12
6d7af49
to
0e8f724
Compare
ForsakenHarmony
changed the title
fix: don't escape base path in ecmascript runtime to allow for URLs
chore: update turbopack
Jan 24, 2024
ForsakenHarmony
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
January 24, 2024 20:14
kwonoj
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turbopack Updates
Closes PACK-2282
Fixes #60891 via vercel/turbo#7093