Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filesystempublicroutes test for Turbopack #61132

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jan 25, 2024

What?

exportPathMap didn't work when Turbopack was enabled because the serializeNextConfig function mutates the original values, overriding exportPathMap.

This PR changes the serialization to copy the object and mutate only the copied object.

Also refactored the test that was checking _next, the better way to test that is to have the page render something dynamically, which is what is added in this PR.

Closes NEXT-2225

Copy link
Member Author

timneutkens commented Jan 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Jan 25, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
buildDuration 11.8s 11.7s N/A
buildDurationCached 6s 4.9s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +992 B
nextStartRea..uration (ms) 426ms 426ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
index.html gzip 527 B 529 B N/A
link.html gzip 539 B 541 B N/A
withRouter.html gzip 521 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
middleware-b..fest.js gzip 625 B 622 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 01-25-Fix_filesystempublicroutes_test_for_Turbopack Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.7 kB 95.7 kB
app-page-tur..prod.js gzip 96.3 kB 96.3 kB
app-page-tur..prod.js gzip 90.9 kB 90.9 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.2 kB 90.2 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.6 kB 21.6 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.42 kB 9.42 kB
pages-api.ru...dev.js gzip 9.69 kB 9.69 kB
pages-api.ru..prod.js gzip 9.42 kB 9.42 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.6 kB 22.6 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 932 kB 932 kB
Commit: bcc7082

@ijjk
Copy link
Member

ijjk commented Jan 25, 2024

Failing test suites

Commit: bcc7082

pnpm test-dev test/e2e/app-dir/app/index.test.ts (PPR)

  • app dir - basic > known bugs > should support React cache > server component client-navigation
Expand output

● app dir - basic › known bugs › should support React cache › server component client-navigation

expect(received).toBe(expected) // Object.is equality

Expected: "0.208788532179625"
Received: "0.08418260790234444"

  1544 |           const val1 = await browser.elementByCss('#value-1').text()
  1545 |           const val2 = await browser.elementByCss('#value-2').text()
> 1546 |           expect(val1).toBe(val2)
       |                        ^
  1547 |         })
  1548 |
  1549 |         it('client component', async () => {

  at Object.toBe (e2e/app-dir/app/index.test.ts:1546:24)

Read more about building and testing Next.js in contributing.md.

@timneutkens timneutkens merged commit 9cc7167 into canary Jan 25, 2024
66 of 68 checks passed
@timneutkens timneutkens deleted the 01-25-Fix_filesystempublicroutes_test_for_Turbopack branch January 25, 2024 13:44
@github-actions github-actions bot added the locked label Feb 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants