Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove sentry from the externals list #61194

Merged
merged 2 commits into from
Jan 26, 2024
Merged

build: remove sentry from the externals list #61194

merged 2 commits into from
Jan 26, 2024

Conversation

feedthejim
Copy link
Contributor

@feedthejim feedthejim commented Jan 26, 2024 •
edited by padmaia

Context:

  • on app router, we bundle all the code used both on server and client
  • sentry used to be incompatible with that, however a raw require call on production to Sentry leads to a 350ms impact on cold boots/initial load
  • it might be ok to bundle now, let's try it out

Closes NEXT-2250

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jan 26, 2024
@feedthejim feedthejim merged commit 883e958 into canary Jan 26, 2024
60 of 65 checks passed
@feedthejim feedthejim deleted the feedthejim/remove-sentry-external-list branch January 26, 2024 10:24
@github-actions github-actions bot added the locked label Feb 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lforst lforst lforst approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feedthejim @lforst @ijjk