-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(next-core): consolidate custom ecma transform rules #61481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Turbopack
Related to Turbopack with Next.js.
created-by: Turbopack team
PRs by the turbopack team
type: next
labels
Feb 1, 2024
kwonoj
changed the title
refactor(next-core): consolidate custom ecma transform rules
[DONOTMERGE] [WIP] refactor(next-core): consolidate custom ecma transform rules
Feb 1, 2024
kwonoj
force-pushed
the
refactor-deprecate-ecma-transforms
branch
from
February 1, 2024 00:56
e11e7b0
to
c458ace
Compare
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
|
Tests Passed |
kwonoj
force-pushed
the
refactor-deprecate-ecma-transforms
branch
8 times, most recently
from
February 2, 2024 01:22
e0ba2ca
to
4753906
Compare
kwonoj
force-pushed
the
refactor-deprecate-ecma-transforms
branch
2 times, most recently
from
February 2, 2024 19:20
df09f9d
to
8ae9571
Compare
kwonoj
force-pushed
the
refactor-deprecate-ecma-transforms
branch
from
February 2, 2024 20:23
8ae9571
to
c14232c
Compare
kwonoj
changed the title
[DONOTMERGE] [WIP] refactor(next-core): consolidate custom ecma transform rules
refactor(next-core): consolidate custom ecma transform rules
Feb 2, 2024
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
February 2, 2024 20:25
wbinnssmith
approved these changes
Feb 2, 2024
ForsakenHarmony
pushed a commit
to vercel/turbo
that referenced
this pull request
Feb 2, 2024
### Description vercel/next.js#61481 cleans up the usage of deprecated options, remove it from turbopack itself. Closes PACK-2370
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Turbopack team
PRs by the turbopack team
Font (next/font)
Related to Next.js Font Optimization.
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates how we inject specific, custom ecma transforms for the each context.
Previously we had 2 different way to apply custom transforms via ecmatransform plugin / custom rules, but it could create some conflict in order as well as can be confusing between how it gets created. PR uses new moduleruleeffect instead, consolidates all of the references into single way.
Closes PACK-2342