Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(next-core): consolidate custom ecma transform rules #61481

Merged
merged 12 commits into from
Feb 2, 2024

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 1, 2024

This PR consolidates how we inject specific, custom ecma transforms for the each context.

Previously we had 2 different way to apply custom transforms via ecmatransform plugin / custom rules, but it could create some conflict in order as well as can be confusing between how it gets created. PR uses new moduleruleeffect instead, consolidates all of the references into single way.

Closes PACK-2342

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Feb 1, 2024
@kwonoj kwonoj changed the title refactor(next-core): consolidate custom ecma transform rules [DONOTMERGE] [WIP] refactor(next-core): consolidate custom ecma transform rules Feb 1, 2024
@kwonoj kwonoj force-pushed the refactor-deprecate-ecma-transforms branch from e11e7b0 to c458ace Compare February 1, 2024 00:56
@ijjk
Copy link
Member

ijjk commented Feb 1, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
buildDuration 11.6s 11.6s N/A
buildDurationCached 6.1s 5.3s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 427ms 434ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.9 kB 29.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 237 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
index.html gzip 528 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
middleware-b..fest.js gzip 626 B 622 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js refactor-deprecate-ecma-transforms Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: c14232c

@ijjk
Copy link
Member

ijjk commented Feb 1, 2024

Tests Passed

@kwonoj kwonoj force-pushed the refactor-deprecate-ecma-transforms branch 8 times, most recently from e0ba2ca to 4753906 Compare February 2, 2024 01:22
@ijjk ijjk added the Font (next/font) Related to Next.js Font Optimization. label Feb 2, 2024
@kwonoj kwonoj force-pushed the refactor-deprecate-ecma-transforms branch 2 times, most recently from df09f9d to 8ae9571 Compare February 2, 2024 19:20
@kwonoj kwonoj force-pushed the refactor-deprecate-ecma-transforms branch from 8ae9571 to c14232c Compare February 2, 2024 20:23
@kwonoj kwonoj changed the title [DONOTMERGE] [WIP] refactor(next-core): consolidate custom ecma transform rules refactor(next-core): consolidate custom ecma transform rules Feb 2, 2024
@kwonoj kwonoj marked this pull request as ready for review February 2, 2024 20:25
@kwonoj kwonoj merged commit fc22d28 into canary Feb 2, 2024
69 checks passed
@kwonoj kwonoj deleted the refactor-deprecate-ecma-transforms branch February 2, 2024 20:58
ForsakenHarmony pushed a commit to vercel/turbo that referenced this pull request Feb 2, 2024
### Description

vercel/next.js#61481 cleans up the usage of
deprecated options, remove it from turbopack itself.

Closes PACK-2370
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team Font (next/font) Related to Next.js Font Optimization. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants