Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .env hmr for Node.js runtime in Turbopack #61504

Merged

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Feb 1, 2024

What?

Whenever .env related files or tsconfig/jsconfig changes there's a call to invalidate(), as far as I found the only call to invalidate() even, which wasn't implemented for Turbopack yet. For NEXT_PUBLIC_ changes normal Turbopack HMR will kick in already but this test was checking env vars that do not affect the compiled output, so Turbopack would not trigger a HMR as no inputs changed. Similarly webpack doesn't either and it implements this call in a similar way.

For edge runtime there's a different bug where changes are not propagated even when you refresh, so while this change does fix another bug for edge runtime it doesn't solve that underlying issue where the values don't update to begin with. I'll investigate that next.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @timneutkens and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Feb 1, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
buildDuration 11.7s 11.6s N/A
buildDurationCached 6.3s 5.2s N/A
nodeModulesSize 200 MB 200 MB ⚠️ +1.5 kB
nextStartRea..uration (ms) 431ms 420ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.9 kB 29.9 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 240 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
index.html gzip 527 B 526 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 523 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Next Runtimes
vercel/next.js canary vercel/next.js 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: 28483b2

@timneutkens timneutkens merged commit ffd5732 into canary Feb 1, 2024
69 checks passed
@timneutkens timneutkens deleted the 02-01-Fix_.env_hmr_for_Node.js_runtime_in_Turbopack branch February 1, 2024 17:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants