Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): support wasm32-* build target #61586

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Feb 2, 2024

What?

This PR introduces a ground work to generate wasm bindings package from our napi bindings. This doesn't actually replace anything yet, however aim to establish our napi bindings package can be built against wasm32 target.

Why?

We currently have two bindings package to generate native / wasm target support, one for napi and one other for wasm. Recently napi-rs started to support to generate bindings for the wasm directly - which means we can get rid of the wasm-pack based bindings code entirely and maintain a single bindings code only.

This'll makes our next-swc simpler as well, since the invocation to the bindings now becomes identical we don't have to additional wasm specific logics to invoke functions (i.e transform, transformsync..). Also napi generates wasi-supported wasm bindings, provides few more features to the current wasm bindings.

Good

  • Async napi binding fn works transparently (transform, minify...)
  • (Experimental) thread supports depends on node.js runtime
  • Wasi support: i.e it can even read filesystem directly!

Things to consider

  • node.js's wasi support is experimental yet
  • napi-rs's wasm support is in beta yet, specifically packaging generated wasm output.

Due to things to consider reasons, this PR does not replace existing wasm target yet. We should be able to plan out things later.

What happens to the turbopack api in napi bindings?

Simply put, this does not support turbopack in wasm. Build works by disabling turbopack (more notably, underlying dependency doesn't support wasm) features. It is something to explore separately.

Closes PACK-2367

There is a branch at #61586 shows quick demo for importing, running sync / async / read external files.

@ijjk ijjk added created-by: Turbopack team PRs by the turbopack team type: next labels Feb 2, 2024
Copy link

socket-security bot commented Feb 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@napi-rs/cli@2.18.0 None 0 6.19 MB broooooklyn
npm/@napi-rs/triples@1.2.0 None 0 13.1 kB broooooklyn

🚮 Removed packages: npm/@napi-rs/cli@2.16.2, npm/@napi-rs/triples@1.1.0

View full report↗︎

@ijjk
Copy link
Member

ijjk commented Feb 2, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js napi-wasi-build Change
buildDuration 11.9s 11.8s N/A
buildDurationCached 6.3s 5.3s N/A
nodeModulesSize 196 MB 196 MB N/A
nextStartRea..uration (ms) 427ms 431ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js napi-wasi-build Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.7 kB 29.7 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 239 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js napi-wasi-build Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js napi-wasi-build Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 501 B N/A
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.19 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 106 B 106 B
Client Build Manifests
vercel/next.js canary vercel/next.js napi-wasi-build Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js napi-wasi-build Change
index.html gzip 529 B 526 B N/A
link.html gzip 540 B 537 B N/A
withRouter.html gzip 524 B 521 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js napi-wasi-build Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 149 kB 149 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js napi-wasi-build Change
middleware-b..fest.js gzip 621 B 625 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 47.4 kB 47.4 kB N/A
edge-runtime..pack.js gzip 1.94 kB 1.94 kB
Overall change 1.94 kB 1.94 kB
Next Runtimes
vercel/next.js canary vercel/next.js napi-wasi-build Change
app-page-exp...dev.js gzip 166 kB 166 kB
app-page-exp..prod.js gzip 95.1 kB 95.1 kB
app-page-tur..prod.js gzip 96.9 kB 96.9 kB
app-page-tur..prod.js gzip 91.4 kB 91.4 kB
app-page.run...dev.js gzip 135 kB 135 kB
app-page.run..prod.js gzip 90 kB 90 kB
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route-tu..prod.js gzip 14.6 kB 14.6 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.6 kB 14.6 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 922 kB 922 kB
Commit: 81cebff

@kwonoj kwonoj mentioned this pull request Feb 2, 2024
@kwonoj kwonoj marked this pull request as ready for review February 2, 2024 19:10
@kwonoj kwonoj requested review from jh3y and molebox and removed request for a team February 2, 2024 19:10
@ijjk
Copy link
Member

ijjk commented Feb 5, 2024

Tests Passed

@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Feb 6, 2024
@kwonoj kwonoj merged commit 9cadae5 into canary Feb 6, 2024
69 checks passed
@kwonoj kwonoj deleted the napi-wasi-build branch February 6, 2024 18:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants