Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbopack): serve google fonts locally and allow preloading them #61596

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

ForsakenHarmony
Copy link
Member

What?

Adds support for preloading google fonts.

Closes PACK-2351

@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Feb 2, 2024
@ForsakenHarmony
Copy link
Member Author

ForsakenHarmony commented Feb 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ForsakenHarmony and the rest of your teammates on Graphite Graphite

@ijjk
Copy link
Member

ijjk commented Feb 2, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Feb 2, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
buildDuration 11.8s 11.9s N/A
buildDurationCached 6.5s 5s N/A
nodeModulesSize 200 MB 200 MB
nextStartRea..uration (ms) 408ms 409ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
3f784ff6-HASH.js gzip 53.4 kB 53.4 kB
423.HASH.js gzip 185 B 181 B N/A
68-HASH.js gzip 29.8 kB 29.8 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 238 B 240 B N/A
main-HASH.js gzip 31.8 kB 31.8 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 502 B 502 B
css-HASH.js gzip 320 B 322 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 256 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 368 B 369 B N/A
image-HASH.js gzip 4.18 kB 4.18 kB N/A
index-HASH.js gzip 257 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB N/A
routerDirect..HASH.js gzip 310 B 311 B N/A
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 306 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 608 B 608 B
Client Build Manifests
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
index.html gzip 526 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 521 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
edge-ssr.js gzip 94 kB 94 kB N/A
page.js gzip 150 kB 150 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
middleware-b..fest.js gzip 626 B 623 B N/A
middleware-r..fest.js gzip 151 B 149 B N/A
middleware.js gzip 37.6 kB 37.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js hrmny/pack-2351-preload-google-fonts Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 95.8 kB 95.8 kB
app-page-tur..prod.js gzip 96.4 kB 96.4 kB
app-page-tur..prod.js gzip 91 kB 91 kB
app-page.run...dev.js gzip 142 kB 142 kB
app-page.run..prod.js gzip 90.3 kB 90.3 kB
app-route-ex...dev.js gzip 22.2 kB 22.2 kB
app-route-ex..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route-tu..prod.js gzip 14.5 kB 14.5 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 14.5 kB 14.5 kB
pages-api-tu..prod.js gzip 9.43 kB 9.43 kB
pages-api.ru...dev.js gzip 9.7 kB 9.7 kB
pages-api.ru..prod.js gzip 9.43 kB 9.43 kB
pages-turbo...prod.js gzip 22 kB 22 kB
pages.runtim...dev.js gzip 22.7 kB 22.7 kB
pages.runtim..prod.js gzip 22 kB 22 kB
server.runti..prod.js gzip 49.7 kB 49.7 kB
Overall change 933 kB 933 kB
Commit: dd72771

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2352-only-preload-fonts-that-dont-opt-out branch from ae7e032 to 3314a08 Compare February 2, 2024 22:23
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/pack-2351-preload-google-fonts branch from b9f34b9 to e657dda Compare February 2, 2024 22:23
@ijjk ijjk added the Font (next/font) Related to Next.js Font Optimization. label Feb 2, 2024
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review February 2, 2024 22:23
Base automatically changed from hrmny/pack-2352-only-preload-fonts-that-dont-opt-out to canary February 3, 2024 18:53
@timneutkens timneutkens force-pushed the hrmny/pack-2351-preload-google-fonts branch from e657dda to dd72771 Compare February 3, 2024 18:55
@timneutkens timneutkens merged commit cb77a9c into canary Feb 3, 2024
68 checks passed
@timneutkens timneutkens deleted the hrmny/pack-2351-preload-google-fonts branch February 3, 2024 20:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team Font (next/font) Related to Next.js Font Optimization. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants